Opened 12 years ago

Closed 12 years ago

#9951 closed defect (fixed)

Missing package init file 'sage/tests/french_book/__init__.py'

Reported by: Mitesh Patel Owned by: Jason Grout
Priority: minor Milestone: sage-4.6
Component: misc Keywords:
Cc: ylchapuy, Paul Zimmermann Merged in: sage-4.6.alpha2
Authors: Leif Leonhardy Reviewers: Paul Zimmermann
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by Mitesh Patel)

Running sage -b with 4.6.alpha1 gives:

[...]
running build_py
package init file 'sage/tests/french_book/__init__.py' not found (or not a regular file)
package init file 'sage/tests/french_book/__init__.py' not found (or not a regular file)
running build_ext
[...]

Leif Leonhardy reported the missing files on sage-release.

The solution is to add an "empty" __init__.py file. Mercurial may complain if the file is truly empty. We can use

# This comment is here so the file is non-empty (so Mercurial will check it in).

say, instead.

This is a follow-up to #9395.

Attachments (1)

trac_9951-add_non-empty_fake_init_file_to_tests_french_book.patch (554 bytes) - added by Leif Leonhardy 12 years ago.
Apply to Sage library

Download all attachments as: .zip

Change History (9)

comment:1 Changed 12 years ago by Mitesh Patel

Description: modified (diff)

comment:2 Changed 12 years ago by David Kirkby

I made the mistake the other day of creating an empty file. Mercruial checked it in OK.

comment:3 in reply to:  2 Changed 12 years ago by Leif Leonhardy

Replying to drkirkby:

I made the mistake the other day of creating an empty file. Mercruial checked it in OK.

Yeah, it is properly checked it, but exporting it gives

# HG changeset patch
# User Leif Leonhardy <not.really@online.de>
# Date 1284952693 -7200
# Node ID eb739c32247985cc9923bb8dbdebf1f7eb404666
# Parent  81b3de2e81408620d6d68f022cd7d834880fa029
#9951 Add (empty) sage/tests/french_book/__init__.py file to avoid warnings.

# HG changeset patch
# User Leif Leonhardy <not.really@online.de>
# Date 1284953161 -7200
# Node ID 87a65b1dbf4f7fc9dd0e468724924363e0d9072c
# Parent  eb739c32247985cc9923bb8dbdebf1f7eb404666
#9951 ... and fill it such that Mercurial will produce a proper patch :/

diff -r eb739c322479 -r 87a65b1dbf4f sage/tests/french_book/__init__.py
--- a/sage/tests/french_book/__init__.py	Mon Sep 20 05:18:13 2010 +0200
+++ b/sage/tests/french_book/__init__.py	Mon Sep 20 05:26:01 2010 +0200
@@ -0,0 +1,1 @@
+# This comment is here so the file is non-empty (so Mercurial will check it in).

(I.e., the patch(es) won't apply properly.) :/

Changed 12 years ago by Leif Leonhardy

Apply to Sage library

comment:4 Changed 12 years ago by Leif Leonhardy

Status: newneeds_review

Non-empty patch is up.

comment:5 Changed 12 years ago by Paul Zimmermann

sorry, I don't know how to review this patch. On my side, sage -b works with the vanilla sage-4.6.alpha1.

comment:6 in reply to:  5 Changed 12 years ago by Leif Leonhardy

Replying to zimmerma:

sorry, I don't know how to review this patch. On my side, sage -b works with the vanilla sage-4.6.alpha1.

If it wouldn't work, the priority of this ticket would be blocker rather than minor. ;-)

The patch just avoids potentially annoying or confusing warning messages. To see the difference, do for example:

~/Sage/sage-4.6.alpha1/devel/sage-main$ touch sage/tests/french_book/numbertheory.py 
~/Sage/sage-4.6.alpha1/devel/sage-main$ ../../sage -b     
----------------------------------------------------------
sage: Building and installing modified Sage library files.


Installing c_lib
scons: `install' is up to date.
Updating Cython code....
Execute 0 commands (using 0 threads)
Time to execute 0 commands: 0.0640869140625 seconds
Finished compiling Cython code (time = 0.421274900436 seconds)
running install
running build
running build_py
package init file 'sage/tests/french_book/__init__.py' not found (or not a regular file)
copying sage/tests/french_book/numbertheory.py -> build/lib.linux-x86_64-2.6/sage/tests/french_book
package init file 'sage/tests/french_book/__init__.py' not found (or not a regular file)
running build_ext
Total time spent compiling C/C++ extensions:  0.0187819004059 seconds.
running install_lib
copying build/lib.linux-x86_64-2.6/sage/tests/french_book/numbertheory.py -> /home/leif/Sage/sage-4.6.alpha1/local/lib/python2.6/site-packages/sage/tests/french_book
byte-compiling /home/leif/Sage/sage-4.6.alpha1/local/lib/python2.6/site-packages/sage/tests/french_book/numbertheory.py to numbertheory.pyc
running install_egg_info
Removing /home/leif/Sage/sage-4.6.alpha1/local/lib/python2.6/site-packages/sage-0.0.0-py2.6.egg-info
Writing /home/leif/Sage/sage-4.6.alpha1/local/lib/python2.6/site-packages/sage-0.0.0-py2.6.egg-info

real    0m1.590s
user    0m1.110s
sys     0m0.300s

Then apply the patch and retry it. (In fact, you should not even have to touch the file, the messages should be there regardless of files being modified or not.)

comment:7 Changed 12 years ago by Paul Zimmermann

Authors: Leif Leonhardy
Milestone: sage-4.6
Reviewers: Paul Zimmermann
Status: needs_reviewpositive_review

with the patch, I get:

tarte% ../../sage -b

----------------------------------------------------------
sage: Building and installing modified Sage library files.


Installing c_lib
scons: `install' is up to date.
Updating Cython code....
Time to execute 0 commands: 1.09672546387e-05 seconds
Finished compiling Cython code (time = 0.345225095749 seconds)
running install
running build
running build_py
copying sage/tests/french_book/__init__.py -> build/lib.linux-x86_64-2.6/sage/tests/french_book
running build_ext
Total time spent compiling C/C++ extensions:  0.017902135849 seconds.
running install_lib
copying build/lib.linux-x86_64-2.6/sage/tests/french_book/__init__.py -> /tmp/sage-4.6.alpha1/local/lib/python2.6/site-packages/sage/tests/french_book
byte-compiling /tmp/sage-4.6.alpha1/local/lib/python2.6/site-packages/sage/tests/french_book/__init__.py to __init__.pyc
running install_egg_info
Removing /tmp/sage-4.6.alpha1/local/lib/python2.6/site-packages/sage-0.0.0-py2.6.egg-info
Writing /tmp/sage-4.6.alpha1/local/lib/python2.6/site-packages/sage-0.0.0-py2.6.egg-info

real    0m1.459s
user    0m1.145s
sys     0m0.233s

thus a positive review.

Paul

comment:8 Changed 12 years ago by Mitesh Patel

Merged in: sage-4.6.alpha2
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.