Changes between Version 93 and Version 94 of Ticket #9944


Ignore:
Timestamp:
05/23/11 18:46:19 (8 years ago)
Author:
SimonKing
Comment:

I hope it is OK that I modified one test in sage.rings.polynomial.polynomial_ring, by the new patch trac9944_addendum.patch.

That test used to be

sage: QQ['y'] < QQ['x']
False
sage: QQ['y'] < QQ['z']
True

But that is unsafe, because this ticket removes the custom __cmp__ method of polynomial rings. So, the comparison relies on virtually random data such as id(QQ['x']), if I am not mistaken.

Therefore, it seems safer to me to replace it by

sage: QQ['y'] != QQ['x']
True
sage: QQ['y'] != QQ['z']
True

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #9944

    • Property Status changed from positive_review to needs_work
  • Ticket #9944 – Description

    v93 v94  
    88  5. [attachment:trac9944_abvar_endomorphism.patch]
    99  6. [attachment:trac9944_faster_and_cleaner_coercion.2.patch]
     10  7. [attachment:trac9944_addendum.patch]  (needs review)
    1011
    1112'''Note'''
     
    1819  5. [attachment:trac9944_abvar_endomorphism.patch]
    1920  6. [attachment:trac9944_faster_and_cleaner_coercion.patch] (Note the name difference to 6. above)
     21  7. [attachment:trac9944_addendum.patch] (needs review)