Opened 11 years ago
Closed 11 years ago
#9942 closed defect (fixed)
Fix CHomP-related doctest errors
Reported by: | jhpalmieri | Owned by: | jhpalmieri |
---|---|---|---|
Priority: | minor | Milestone: | sage-4.6.2 |
Component: | algebraic topology | Keywords: | |
Cc: | mpatel | Merged in: | sage-4.6.2.alpha1 |
Authors: | John Palmieri | Reviewers: | Marshall Hampton |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
With the optional CHomP package in 4.5.3 on sage.math, I get some doctest failures:
sage -t -long -only-optional=chomp "devel/sage/sage/homology/cell_complex.py" ********************************************************************** File "/mnt/usb1/scratch/mpatel/tmp/sage-4.5.3-chomp/devel/sage/sage/homology/cell_complex.py", line 470: sage: S2.homology(dim=2, generators=True) # optional - CHomP Expected: (Z, [(0, 1, 2) - (0, 1, 3) + (0, 2, 3) - (1, 2, 3)]) Got: (Z, [-(0, 1, 2) + (0, 1, 3) - (0, 2, 3) + (1, 2, 3)])
Attachments (1)
Change History (10)
comment:1 Changed 11 years ago by
comment:2 Changed 11 years ago by
Hi Marshall,
I think you're seeing the problem reported on #9940: equality (or inequality?) testing for abelian groups is broken.
comment:3 Changed 11 years ago by
- Status changed from new to needs_review
I see this failure on various linux machines (sage.math and the skynet machines eno, flavius, lena, sextus, taurus). The tests seem to pass on OS X and Solaris (fulvia) and OpenSolaris (hawk). With the attached patch, it passes on all of these machines.
comment:4 Changed 11 years ago by
The tests seem to pass on OS X and Solaris (fulvia) and OpenSolaris?
(By "seem to pass", I mean that they pass on all of the machines on which I've tested them, but I can't guarantee that they would pass on all Solaris and/or OpenSolaris boxes.)
comment:5 Changed 11 years ago by
I've been doing some more testing of CHomP-related doctests and have found a few more failures of this same type: on some platforms, one generator is chosen, and other platforms a different (but mathematically valid) generator is chosen. I've fixed these in the new patch. Also, the file sage/homology/tests.py
takes too long to test on some platforms (with -long -only-optional=chomp
), so I've shortened the tests there.
Changed 11 years ago by
comment:6 Changed 11 years ago by
- Status changed from needs_review to positive_review
Looks good and all tests pass on OS X 10.5, 10.6, and linux (64-bit Ubuntu 10.04, intel i7 860). So I think I can give this a positive review.
comment:7 Changed 11 years ago by
- Milestone changed from sage-4.6.1 to sage-4.6.2
comment:8 Changed 11 years ago by
- Reviewers set to Marshall Hampton
comment:9 Changed 11 years ago by
- Merged in set to sage-4.6.2.alpha1
- Resolution set to fixed
- Status changed from positive_review to closed
On OS X 10.6, cell_complex passes all tests (with the same options as above), but I do get: