Opened 10 years ago

Closed 10 years ago

#9931 closed defect (fixed)

Implement conversion from EllipticCurvePoint to PARI

Reported by: jdemeyer Owned by: cremona
Priority: major Milestone: sage-4.6
Component: elliptic curves Keywords: elliptic curve point pari
Cc: Merged in: sage-4.6.alpha2
Authors: Jeroen Demeyer Reviewers: David Loeffler
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Currently, points on elliptic curves cannot automatically be converted to PARI: 

sage: E = EllipticCurve([0,0,0,3,0])
sage: P = E.point([1,2]); P
(1 : 2 : 1)
sage: pari(P)
Traceback (most recent call last):
...
RuntimeError: evaluating PARI string

Attachments (1)

9931_ell_point_pari.patch​ (14.1 KB) - added by jdemeyer 10 years ago.

Download all attachments as: .zip

Change History (5)

Changed 10 years ago by jdemeyer

comment:1 Changed 10 years ago by jdemeyer

  • Status changed from new to needs_review

comment:2 Changed 10 years ago by jdemeyer

Note that the patch removes _pari_ for elliptic curves over p-adic and finite fields. This is justified because the general case covers these special cases (and doctests have been copied to check that).

comment:3 Changed 10 years ago by davidloeffler

  • Authors set to Jeroen Demeyer
  • Reviewers set to David Loeffler
  • Status changed from needs_review to positive_review

Looks fine to me.

comment:4 Changed 10 years ago by mpatel

  • Merged in set to sage-4.6.alpha2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.