Opened 9 years ago

Closed 9 years ago

#9924 closed defect (fixed)

Doctest error in sage/geometry/polyhedra.py

Reported by: mpatel Owned by: mvngu
Priority: blocker Milestone: sage-4.6
Component: doctest coverage Keywords:
Cc: AlexGhitza, novoselt, vbraun Merged in: sage-4.6.alpha1
Authors: Alex Ghitza Reviewers: Andrey Novoseltsev
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

I get this doctest error with a trial 4.6.alpha1 on sage.math and many other Sage cluster and Skynet machines:

sage -t -long  devel/sage/sage/geometry/polyhedra.py
**********************************************************************
File "/mnt/usb1/scratch/mpatel/tmp/sage-4.6.alpha1/devel/sage-main/sage/geometry/polyhedra.py", line 1270:
    sage: p1.projection().show() + p2.projection().show() + p3.projection().show()
Expected nothing
Got:
    doctest:4555: DeprecationWarning: (Since Sage 4.6) use the option 'width' instead of 'thickness'
    <BLANKLINE>
**********************************************************************

Attachments (1)

trac_9924.patch (926 bytes) - added by AlexGhitza 9 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 9 years ago by mpatel

If it's feasible to create a patch now, I can merge it into 4.6.alpha1, while I wait for a response to a build error at #4000.

comment:2 Changed 9 years ago by mpatel

  • Cc AlexGhitza added

comment:3 Changed 9 years ago by AlexGhitza

I'm not seeing this in 4.6.alpha0. It looks like some graphics ticket you merged between alpha0 and alpha1 introduced a new deprecation warning. Any idea which ticket it might be?

If we can find that out, it shouldn't be difficult to change either the code or the doctest to use the new non-deprecated way of doing things.

comment:4 Changed 9 years ago by vbraun

Ticket #7154 changed the options for point/arrow thickness and was merged in 4.6.alpha1. I didn't realize that this impacts the polyhedra package, but of course it does. Anyways, the obvious patch is to change the option name in polyhedra.py.

comment:5 Changed 9 years ago by mpatel

By the way, the unofficial, trial 4.6.alpha1 is in /home/release/sage-4.6.alpha1 on the Sage cluster.

Changed 9 years ago by AlexGhitza

comment:6 Changed 9 years ago by AlexGhitza

  • Status changed from new to needs_review

OK, a fairly trivial patch is now up.

comment:7 Changed 9 years ago by novoselt

  • Authors set to Alex Ghitza
  • Reviewers set to Andrey Novoseltsev
  • Status changed from needs_review to positive_review

Solves the for me issue!

comment:8 Changed 9 years ago by mpatel

  • Merged in set to sage-4.6.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed

Thanks!

Note: See TracTickets for help on using tickets.