Opened 10 years ago
Last modified 6 years ago
#9912 new defect
extraneous argument in deprecation in #7154
Reported by: | jason | Owned by: | jason, was |
---|---|---|---|
Priority: | major | Milestone: | sage-6.4 |
Component: | graphics | Keywords: | |
Cc: | ryan | Merged in: | |
Authors: | Reviewers: | ||
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
In #7154, the rename_keyword deprecation decorator has an extra argument. Right now, it's:
@rename_keyword(deprecated='Sage 4.6', deprecated_option='thickness', thickness='width')
but should just be
@rename_keyword(deprecated='Sage 4.6', thickness='width')
My bad for not catching this in the review stage.
Change History (7)
comment:1 Changed 10 years ago by
comment:2 follow-up: ↓ 3 Changed 10 years ago by
Leif: is that the only failure in all long doctests (i.e., ptestlong or similar?)
If not, I'll run ptestlong to check.
comment:3 in reply to: ↑ 2 Changed 10 years ago by
Replying to jason:
Leif: is that the only failure in all long doctests (i.e., ptestlong or similar?)
The only one related to this (DeprecationWarning
) with the unreleased 4.6.alpha1.
If you put the deprecation warning into the doctest ("expected"), don't forget to not hard-code the line number (from ncadoctest.py
!).
comment:4 Changed 7 years ago by
- Milestone changed from sage-5.11 to sage-5.12
comment:5 Changed 7 years ago by
- Milestone changed from sage-6.1 to sage-6.2
comment:6 Changed 7 years ago by
- Milestone changed from sage-6.2 to sage-6.3
comment:7 Changed 6 years ago by
- Milestone changed from sage-6.3 to sage-6.4
Just for the record, this then also needs to be fixed: