Changes between Version 2 and Version 7 of Ticket #9910


Ignore:
Timestamp:
11/27/10 19:24:52 (10 years ago)
Author:
mvngu
Comment:

I'm OK with most of your patch. But here are some general comments:

  • I don't quite understand this documentation:
            - ``s`` (vertex) -- forces the source of the path. Set to               
              ``None`` by default.                                                  
                                                                                    
            - ``t`` (vertex) -- forces the destination of the path. Set to          
              ``None`` by default.
    
    What do you mean by "forces", etc. You need to elaborate here.
  • The following code block
                if self._directed:
                    from sage.graphs.all import DiGraph
                    return [0, DiGraph()] if weighted else DiGraph()
                else:
                    from sage.graphs.all import Graph
                    return [0, Graph()] if weighted else Graph()
    
    is equivalent to
                if self._directed:
                    from sage.graphs.all import DiGraph
                    return [0, DiGraph()] if weighted else DiGraph()
                from sage.graphs.all import Graph
                return [0, Graph()] if weighted else Graph()
    
  • You really need to start seriously writing Python code that conforms to Python coding conventions (wherever possible); see PEP 8 for more information.

Most of the above issues are fixed in my reviewer patch.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #9910

    • Property Authors changed from to Nathann Cohen
    • Property Cc mvngu added
    • Property Reviewers changed from to Robert Miller, Minh Van Nguyen
  • Ticket #9910 – Description

    v2 v7  
    66    * #10043
    77
    8 Nathann
     8'''Apply:'''
     9
     10 1. [attachment:trac_9910.patch]
     11 1. [attachment:trac-9910_reviewer.patch]