Opened 9 years ago

Closed 9 years ago

#9900 closed defect (fixed)

better conjugation for special functions

Reported by: burcin Owned by: burcin
Priority: major Milestone: sage-4.6
Component: symbolics Keywords: pynac
Cc: Merged in: sage-4.6.alpha3
Authors: Burcin Erocal Reviewers: Karl-Dieter Crisman
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Add doctests to test enhancements to conjugates of some special functions in pynac/GiNaC.

Attachments (3)

trac_9900_conjugate_doctests.patch (8.6 KB) - added by burcin 9 years ago.
trac_9900_conjugate_doctests-rebase.patch (9.0 KB) - added by kcrisman 9 years ago.
Rebase of original patch with respect to reviewer patches of #9879 and #9881
trac_9900-reviewer.patch (3.9 KB) - added by kcrisman 9 years ago.
Reviewer patch, apply after rebase patch

Download all attachments as: .zip

Change History (9)

Changed 9 years ago by burcin

comment:1 Changed 9 years ago by burcin

  • Authors set to Burcin Erocal
  • Status changed from new to needs_review

attachment:trac_9900_conjugate_doctests.patch adds doctests to reflect the changes in the new pynac version at #9901.

The pynac package includes patches for #9394, #9834, #9878, #9879, #9881 as well as this ticket. See the ticket description of #9901 for the list (and order) of patches associated to the new version.

comment:2 Changed 9 years ago by kcrisman

This patch depends on knowing the branch cuts we wish to use. A followup ticket for giving references for these choices (and/or for making sure they're the same as used for our numerical approximations of these!) is at #10033.

comment:3 Changed 9 years ago by kcrisman

This comes from upstream in Ginac. According to Burcin:

just imported Richard Kreckel's patch from upstream.

comment:4 Changed 9 years ago by kcrisman

  • Reviewers set to Karl-Dieter Crisman

Other than one spot where arccos should be arccosh in the new doctests, this is fine. However, it seems good to add some more doctests, especially for the branch cuts to make sure they stay unsimplified. A patch for this should be done by tomorrow sometime.

Changed 9 years ago by kcrisman

Rebase of original patch with respect to reviewer patches of #9879 and #9881

comment:5 Changed 9 years ago by kcrisman

  • Status changed from needs_review to positive_review

Okay, reviewer patch is ready and coming right up. Positive review.

To release manager: please merge first rebase patch, then reviewer patch.

Changed 9 years ago by kcrisman

Reviewer patch, apply after rebase patch

comment:6 Changed 9 years ago by mpatel

  • Merged in set to sage-4.6.alpha3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.