Opened 11 years ago

Closed 11 years ago

#9898 closed enhancement (fixed)

Clean up and add functions to sage/libs/pari/decl.pxi

Reported by: jdemeyer Owned by: was
Priority: major Milestone: sage-4.6
Component: interfaces Keywords:
Cc: leif Merged in: sage-4.6.alpha2
Authors: Jeroen Demeyer Reviewers: Leif Leonhardy
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by leif)

  • Adds a file sage/libs/pari/declinl.pxi for declarations of inline functions (which is included by sage/libs/pari/decl.pxi).
  • Some clean up of sage/libs/pari/decl.pxi, in particular removing duplicate functions.
  • Adds/updates authors sections.

Attachments (2)

9898_pari_decl.patch (46.8 KB) - added by jdemeyer 11 years ago.
9898_authors.patch (1.9 KB) - added by jdemeyer 11 years ago.
Adds authors to files in sage/libs/pari, apply on top of 9898_pari_decl.patch

Download all attachments as: .zip

Change History (15)

comment:1 Changed 11 years ago by jdemeyer

  • Status changed from new to needs_review

comment:2 Changed 11 years ago by leif

  • Cc leif added

comment:3 follow-up: Changed 11 years ago by leif

s/seperate/separate/

s/This files/This file/

comment:4 in reply to: ↑ 3 Changed 11 years ago by jdemeyer

Replying to leif:

s/seperate/separate/

s/This files/This file/

Done.

comment:5 Changed 11 years ago by leif

Did you upload the wrong patch?

I just noticed the typos are back...

comment:6 Changed 11 years ago by leif

The global t0 in gequal_long() is superfluous.

Changed 11 years ago by jdemeyer

comment:7 Changed 11 years ago by jdemeyer

  • Authors set to Jeroen Demeyer

Done.

comment:8 Changed 11 years ago by leif

  • Reviewers set to Leif Leonhardy
  • Status changed from needs_review to positive_review

Ok, I've now also tested this with Sage 4.6.alpha1 and #9876 (PARI 2.4.3.svn-12577.p7) on Ubuntu 9.04 x86 and Ubuntu 10.04 x86_64 (both ptestlong).

Patch is up-to-date, so positive review.

I've (of course?) not checked if all functions really come from the PARI source files they're claimed to come from. ;-)

It's up to you to convince Mitesh to merge it into 4.6.alpha2. :)

comment:9 Changed 11 years ago by jdemeyer

  • Description modified (diff)

comment:10 follow-up: Changed 11 years ago by leif

Perhaps one should mention that pari/declinl.pxi gets included by pari/decl.pxi.

Add svn snapshot number?

Changed 11 years ago by jdemeyer

Adds authors to files in sage/libs/pari, apply on top of 9898_pari_decl.patch

comment:11 in reply to: ↑ 10 ; follow-up: Changed 11 years ago by jdemeyer

Replying to leif:

Perhaps one should mention that pari/declinl.pxi gets included by pari/decl.pxi.

Done.

Add svn snapshot number?

I don't think that is so relevant (those files would not look that much different for other SVN snapshot numbers). Besides, people can still look at the ticket #9343 for more information.

comment:12 in reply to: ↑ 11 Changed 11 years ago by leif

  • Description modified (diff)

Replying to jdemeyer:

[...] people can still look at the ticket #9343 for more information.

:-)

Btw, is 08-15 a 'symbolic' date?

Positive review for the second patch, too.

comment:13 Changed 11 years ago by mpatel

  • Merged in set to sage-4.6.alpha2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.