#9870 closed defect (fixed)
Clean up Cliquer's spkg-install
Reported by: | drkirkby | Owned by: | leif |
---|---|---|---|
Priority: | minor | Milestone: | sage-6.2 |
Component: | packages: standard | Keywords: | |
Cc: | ncohen, mvngu | Merged in: | |
Authors: | Jeroen Demeyer | Reviewers: | Jean-Pierre Flori |
Report Upstream: | N/A | Work issues: | |
Branch: | 2ffeeb7 (Commits, GitHub, GitLab) | Commit: | |
Dependencies: | #14349 | Stopgaps: |
Description (last modified by )
The spkg-install
file for Cliquer could do with a lot of cleaning up. Some examples of the problems are:
- There are flags set for the C++ and Fortran compilers, though the code is only C.
- There's code to check for a mix of Sun and GNU compilers, which is pointless since there is only 1 compiler used.
- Lots of unnecessary environment variables are set.
- Use
make
instead of$MAKE
. - Runs tests in
spkg-install
instead ofspkg-check
.
None of these issues are currently causing any problems, but should be resolved at some point
Change History (19)
comment:1 Changed 11 years ago by
- Owner changed from GeorgSWeber to leif
comment:2 Changed 11 years ago by
- Cc ncohen added
- Component changed from build to linear programming
comment:3 Changed 11 years ago by
Hello !
There is one technical question you can however answer. Do we need the binary file "cl" so it can be executed from the command line, or is the library libcliquer.so sufficient?
No, the cl file is not used, and this is precisely what the Sage code included in cliquer is useful for : directly calling the library's functions with a Graph object using the Graph structure it expects to find, without having to create an ugly temporary file to call the executable on it :-)
Nathann
comment:4 Changed 11 years ago by
- Cc mvngu added
comment:5 Changed 10 years ago by
Leif, you were keen to take ownership of this. Has anything happened with it?
Dave
comment:6 Changed 10 years ago by
I ask once again. Any chance of you sorting this out Leif, since you wanted to take ownership of it.
Dave
comment:7 Changed 10 years ago by
See #11227 for another issue with cliquer, unrelated to this ticket.
comment:8 Changed 8 years ago by
- Milestone changed from sage-5.11 to sage-5.12
comment:9 Changed 7 years ago by
- Component changed from linear programming to packages: standard
- Description modified (diff)
- Summary changed from Clean up Cliquer's Makefile and spkg-install to Clean up Cliquer's spkg-install
I'll tackle this.
comment:10 Changed 7 years ago by
- Branch set to u/jdemeyer/ticket/9870
- Modified changed from 01/16/14 13:34:00 to 01/16/14 13:34:00
comment:11 Changed 7 years ago by
- Commit set to 5f55f5b15aeccc3c40f62585639b3ffa61852490
- Status changed from new to needs_review
New commits:
f55a304 | python-sage work without cliquer patching (#14349)
|
aecdf29 | module_list: add cl.c to cliquer.so sources (#14349)
|
25edb2f | trac #14349: rebase on 6.1.beta4
|
6253068 | trac #14349: move cl.* to cliquer/
|
9f04e98 | Merge remote-tracking branch 'origin/develop' into HEAD
|
5f55f5b | Clean up cliquer package
|
comment:12 Changed 7 years ago by
- Dependencies set to #14349
comment:13 Changed 7 years ago by
- Milestone changed from sage-6.1 to sage-6.2
comment:14 Changed 7 years ago by
- Branch changed from u/jdemeyer/ticket/9870 to u/jpflori/ticket/9870
- Commit changed from 5f55f5b15aeccc3c40f62585639b3ffa61852490 to 2ffeeb72890fc52b937b259f0f4ca6792a2d5b1d
- Reviewers set to Jean-Pierre Flori
Don't know why trac was not able to merge the branch as I encountered no conflicts when merging it.
I've made a few changes to make the script more like the "new" scripts as described in the dev guide, you may not be happy with them and are very welcome to change them back. Otherwise let's positively review this ticket.
Anyway, I'm going to autotoolify cliquer, post it in a follow-up ticket and suggest it upstream. The Makefile is just too awful right now.
New commits:
92dd8c8 | Merge remote-tracking branch 'trac/develop' into ticket/9870
|
2ffeeb7 | Slight changes to cliquer install script.
|
comment:15 Changed 7 years ago by
I've sent an email upstream about the possibility of releasing an official version including some of the Debian's patches (http://anonscm.debian.org/gitweb/?p=debian-science/packages/cliquer.git;a=tree;f=debian/patches;hb=HEAD) and an autotoolified build system.
comment:16 Changed 7 years ago by
- Status changed from needs_review to positive_review
I think set -e
is a good thing and should be used more. So I reverted that change.
comment:17 Changed 7 years ago by
- Branch changed from u/jpflori/ticket/9870 to u/jdemeyer/ticket/9870
- Modified changed from 02/21/14 06:03:04 to 02/21/14 06:03:04
comment:18 Changed 7 years ago by
- Branch changed from u/jdemeyer/ticket/9870 to 2ffeeb72890fc52b937b259f0f4ca6792a2d5b1d
- Resolution set to fixed
- Status changed from positive_review to closed
comment:19 Changed 7 years ago by
- Commit 2ffeeb72890fc52b937b259f0f4ca6792a2d5b1d deleted
FYI, upstream has nicely answered my questions. They don't really mind cliquer being distributed in different forms in various places and don't plan on releasing any new upstream version "in the next ten years or so (or ever?)".
To tranquilize Dave :-)
I've made several comments at tickets related to Cliquer, e.g. #9833 and #9871.
I think this should then be a follow-up of #9871, despite the numbers.