Opened 11 years ago

Closed 9 years ago

#9867 closed defect (duplicate)

getting rid of endianness-dependent behaviour in GAP random sources

Reported by: dimpase Owned by: joyner
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: group theory Keywords:
Cc: simonking Merged in:
Authors: Reviewers: Dmitrii Pasechnik, Karl-Dieter Crisman
Report Upstream: Fixed upstream, in a later stable release. Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by dimpase)

in the thread [How to deal with GAP's machine dependent random generator?] on sage-devel Simon King mentioned that GAP own random source dependes on endianness of the machine. While Sage sort of takes care of this in misc/randstate.pyx, it still does not fix GAP internals. So, to make it good and proper, we essentially add the fix in misc/randstate.pyx to GAPROOT/src/integer.c, and remove it from misc/randstate.pyx The updated gap spkg is here:

​http://boxen.math.washington.edu/home/dima/packages/gap-4.4.12.p5.spkg

So one needs to install this spkg and apply the patch attached to the ticket. I don't seem to have access to a 64-bit big-endian system, so it would be great to test it there, just in case...

Attachments (1)

trac_9876_gap_MT_endianness.patch​ (1.6 KB) - added by dimpase 11 years ago.

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by dimpase

comment:1 Changed 11 years ago by dimpase

  • Description modified (diff)

comment:2 Changed 11 years ago by dimpase

  • Cc simonking added
  • Report Upstream changed from Completely fixed; Fix reported upstream to Fixed upstream, but not in a stable release.

comment:3 Changed 9 years ago by dimpase

  • Status changed from new to needs_review

comment:4 Changed 9 years ago by dimpase

This will be fixed in #13211. Let us close this one as obsolete.

comment:5 Changed 9 years ago by kcrisman

  • Milestone changed from sage-5.4 to sage-duplicate/invalid/wontfix
  • Reviewers set to Dmitrii Pasechnik, Karl-Dieter Crisman
  • Status changed from needs_review to positive_review

I can confirm that the current code is no longer needed as of #13211; see here.

comment:6 Changed 9 years ago by jdemeyer

  • Report Upstream changed from Fixed upstream, but not in a stable release. to Fixed upstream, in a later stable release.
  • Resolution set to duplicate
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.