Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#9854 closed enhancement (invalid)

make networkx compatibel with numpy-1.4.1

Reported by: maldun Owned by: tbd
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Stefan Reiterer Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by maldun)

In order to finish Ticket #9808 there have to be a small patch applied to networkx.

A small change has to be done in convert.py, namely 

numpy.core.defmatrix

changes to 

numpy.matrixlib.defmatrix

(see the diff for details)

Attachments (3)

convert.py.diff​ (626 bytes) - added by maldun 11 years ago.
changes
convert.py.2.diff​ (1.6 KB) - added by maldun 11 years ago.
Downward compatibel patch
networkx-1.0.1.p0.spkg​ (664.2 KB) - added by maldun 11 years ago.
modified version for networkx to make numpy-1.4.1 compatible

Download all attachments as: .zip

Change History (13)

comment:1 Changed 11 years ago by maldun

  • Description modified (diff)

Changed 11 years ago by maldun

changes

comment:2 Changed 11 years ago by maldun

  • Status changed from new to needs_review

comment:3 Changed 11 years ago by maldun

  • Description modified (diff)

Changed 11 years ago by maldun

Downward compatibel patch

Changed 11 years ago by maldun

modified version for networkx to make numpy-1.4.1 compatible

comment:4 Changed 11 years ago by maldun

  • Description modified (diff)

comment:5 Changed 11 years ago by fbissey

As I mentioned in the numpy upgrade bug we are moving to networkx-1.2. So this bug may be invalid. Check have to be done against networkx-1.2 not 1.0.1.

comment:6 Changed 11 years ago by maldun

Ok like mentioned in #9808 networkx-1.2 works with the numpy packages just fine. But I had to install a new version, because I was not able to just install networkx-1.2 into my old version of sage-4.2. After intalling it and applying the patches it still didn't work correctly. But the patch of 1.0.1 above worked well for me. So it could still be usefull. But I think we could close this ticket then.

comment:7 Changed 11 years ago by maldun

  • Resolution set to fixed
  • Status changed from needs_review to closed

comment:8 follow-up: Changed 11 years ago by mvngu

  • Milestone set to sage-4.5.3
  • Status changed from closed to needs_work

How is this ticket considered fixed? Do you want the attached NetworkX package to be merged in the Sage standard repository? If so, has it been merged yet? If not, you need to explain why you closed this ticket.

comment:9 in reply to: ↑ 8 Changed 11 years ago by fbissey

  • Resolution changed from fixed to invalid
  • Status changed from needs_work to closed

Replying to mvngu:

How is this ticket considered fixed? Do you want the attached NetworkX package to be merged in the Sage standard repository? If so, has it been merged yet? If not, you need to explain why you closed this ticket.

It should have been closed invalid. Numpy-1.4.1 and networkx-1.0.1 don't go along very well together. But it doesn't matter since next sage release will use networkx-1.2 which works well with numpy-1.4.1. I am changing it to "invalid".

comment:10 Changed 11 years ago by mvngu

  • Milestone changed from sage-4.5.3 to sage-duplicate/invalid/wontfix
Note: See TracTickets for help on using tickets.