Opened 11 years ago
Closed 11 years ago
#9841 closed enhancement (fixed)
Make Qhull an optional package
Reported by: | mhampton | Owned by: | mhampton |
---|---|---|---|
Priority: | minor | Milestone: | sage-4.6 |
Component: | geometry | Keywords: | polyhedra, qhull, convex, Delaunay, Voronoi |
Cc: | novoselt, vbraun, mvngu, schilly, mhansen, jdemeyer | Merged in: | |
Authors: | Marshall Hampton | Reviewers: | Volker Braun |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
From the README.txt of Qhull:
Qhull computes convex hulls, Delaunay triangulations, Voronoi diagrams, furthest-site Voronoi diagrams, and halfspace intersections about a point. It runs in 2-d, 3-d, 4-d, or higher. It implements the Quickhull algorithm for computing convex hulls. Qhull handles round-off errors from floating point arithmetic. It can approximate a convex hull.
The program includes options for hull volume, facet area, partial hulls, input transformations, randomization, tracing, multiple output formats, and execution statistics.
First attempt at a spkg is at:
http://sage.math.washington.edu/home/mhampton/qhull-2010.1.spkg
Change History (8)
comment:1 Changed 11 years ago by
- Status changed from new to needs_review
comment:2 Changed 11 years ago by
- Cc novoselt added
comment:3 Changed 11 years ago by
comment:4 Changed 11 years ago by
- Cc vbraun added
comment:5 Changed 11 years ago by
- Reviewers set to Volker Braun
- Status changed from needs_review to positive_review
Looks good to me!
Its a bit odd that qhull uses no buildsystem except for a bare-bones makefile, but then they don't use any external library nor build a shared library. Still, there are a lot of #ifdef's strewn around the source code. In any case, I'm in favor of having it as an optional package.
comment:6 follow-up: ↓ 7 Changed 11 years ago by
- Cc mvngu schilly mhansen jdemeyer added
Harald, Mike, or Minh, could you please add
http://sage.math.washington.edu/home/mhampton/qhull-2010.1.spkg
as an optional package?
comment:7 in reply to: ↑ 6 Changed 11 years ago by
Replying to mpatel:
Harald, Mike, or Minh, could you please add
http://sage.math.washington.edu/home/mhampton/qhull-2010.1.spkg
as an optional package?
Done. See the updated optional spkg page
http://www.sagemath.org/packages/optional/
The new package is now being mirrored.
comment:8 Changed 11 years ago by
- Resolution set to fixed
- Status changed from positive_review to closed
This doesn't require much review - can someone take a look? All this spkg does is install qhull. I have tested on OS X 10.6 and 10.5 and linux.