Opened 12 years ago
Closed 12 years ago
#9838 closed defect (fixed)
Bugfix in WeylCharacterRing __call__ method
Reported by: | Daniel Bump | Owned by: | Daniel Bump |
---|---|---|---|
Priority: | major | Milestone: | sage-4.6.1 |
Component: | group theory | Keywords: | |
Cc: | Sage Combinat CC user | Merged in: | sage-4.6.1.alpha1 |
Authors: | Daniel Bump | Reviewers: | Anne Schilling |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
This addresses a bug that was reported here:
http://groups.google.com/group/sage-combinat-devel/msg/252fd7fa0e297214
The __call__
method of a Weyl Character ring, when style="coroots"
is specified, tries to interpret the arguments as the coroots of a weight; that weight
is then the actual argument. However this is not appropriate if the argument is
not a tuple. Therefore this should be tested.
The patch implements the test.
Attachments (1)
Change History (20)
comment:1 Changed 12 years ago by
Owner: | changed from Alex Ghitza to Daniel Bump |
---|
comment:2 Changed 12 years ago by
Status: | new → needs_review |
---|
comment:3 follow-up: 4 Changed 12 years ago by
Cc: | Sage Combinat CC user added |
---|---|
Component: | algebra → group_theory |
comment:4 Changed 12 years ago by
Status: | needs_review → positive_review |
---|
comment:5 Changed 12 years ago by
Authors: | bump → Daniel Bump |
---|---|
Milestone: | sage-4.6 → sage-4.6.1 |
Reviewers: | → Anne Schilling |
comment:6 Changed 12 years ago by
Status: | positive_review → needs_work |
---|
Please change the commit message of the patch trac_9838.patch (use hg qrefresh -e
for that).
comment:7 follow-up: 8 Changed 12 years ago by
Status: | needs_work → positive_review |
---|
Please change the commit message of the patch trac_9838.patch (use hg qrefresh -e for that).
Done. -Dan
comment:8 Changed 12 years ago by
Status: | positive_review → needs_work |
---|
Replying to bump:
Done. -Dan
Sorry, the ticket number should also be in the first line of the commit message.
Changed 12 years ago by
Attachment: | trac_9838.patch added |
---|
#9838: bugfix in WeylCharac? terRing call method
comment:9 Changed 12 years ago by
Status: | needs_work → positive_review |
---|
Sorry, the ticket number should also be in the first line of the commit message.
Done.
comment:10 Changed 12 years ago by
Merged in: | → sage-4.6.1.alpha0 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
comment:11 Changed 12 years ago by
Merged in: | sage-4.6.1.alpha0 |
---|---|
Status: | closed → needs_work |
comment:12 Changed 12 years ago by
Status: | needs_work → positive_review |
---|
comment:13 follow-up: 18 Changed 12 years ago by
The ticket is still described as resolved:fixed.
I don't think I can revert the fixed status: trac admin has to do that. (It doesn't matter if this won't cause the release manager to forget the patch.)
comment:14 Changed 12 years ago by
Status: | positive_review → closed |
---|
comment:15 Changed 12 years ago by
Resolution: | fixed |
---|---|
Status: | closed → new |
comment:16 Changed 12 years ago by
Status: | new → needs_review |
---|
comment:17 Changed 12 years ago by
Status: | needs_review → positive_review |
---|
comment:18 Changed 12 years ago by
comment:19 Changed 12 years ago by
Merged in: | → sage-4.6.1.alpha1 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Replying to bump:
This is a bug fix. All tests pass!