Opened 12 years ago

Closed 12 years ago

#9838 closed defect (fixed)

Bugfix in WeylCharacterRing __call__ method

Reported by: Daniel Bump Owned by: Daniel Bump
Priority: major Milestone: sage-4.6.1
Component: group theory Keywords:
Cc: Sage Combinat CC user Merged in: sage-4.6.1.alpha1
Authors: Daniel Bump Reviewers: Anne Schilling
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

This addresses a bug that was reported here:

http://groups.google.com/group/sage-combinat-devel/msg/252fd7fa0e297214

The __call__ method of a Weyl Character ring, when style="coroots" is specified, tries to interpret the arguments as the coroots of a weight; that weight is then the actual argument. However this is not appropriate if the argument is not a tuple. Therefore this should be tested.

The patch implements the test.

Attachments (1)

trac_9838.patch (1.5 KB) - added by Daniel Bump 12 years ago.
#9838: bugfix in WeylCharac? terRing call method

Download all attachments as: .zip

Change History (20)

comment:1 Changed 12 years ago by Daniel Bump

Owner: changed from Alex Ghitza to Daniel Bump

comment:2 Changed 12 years ago by Daniel Bump

Status: newneeds_review

comment:3 Changed 12 years ago by Daniel Bump

Cc: Sage Combinat CC user added
Component: algebragroup_theory

comment:4 in reply to:  3 Changed 12 years ago by Anne Schilling

Status: needs_reviewpositive_review

Replying to bump:

This is a bug fix. All tests pass!

comment:5 Changed 12 years ago by Jeroen Demeyer

Authors: bumpDaniel Bump
Milestone: sage-4.6sage-4.6.1
Reviewers: Anne Schilling

comment:6 Changed 12 years ago by Jeroen Demeyer

Status: positive_reviewneeds_work

Please change the commit message of the patch trac_9838.patch (use hg qrefresh -e for that).

comment:7 Changed 12 years ago by Daniel Bump

Status: needs_workpositive_review

Please change the commit message of the patch trac_9838.patch (use hg qrefresh -e for that).

Done. -Dan

comment:8 in reply to:  7 Changed 12 years ago by Jeroen Demeyer

Status: positive_reviewneeds_work

Replying to bump:

Done. -Dan

Sorry, the ticket number should also be in the first line of the commit message.

Changed 12 years ago by Daniel Bump

Attachment: trac_9838.patch added

#9838: bugfix in WeylCharac? terRing call method

comment:9 Changed 12 years ago by Daniel Bump

Status: needs_workpositive_review

Sorry, the ticket number should also be in the first line of the commit message.

Done.

comment:10 Changed 12 years ago by Jeroen Demeyer

Merged in: sage-4.6.1.alpha0
Resolution: fixed
Status: positive_reviewclosed

comment:11 Changed 12 years ago by Jeroen Demeyer

Merged in: sage-4.6.1.alpha0
Status: closedneeds_work

comment:12 Changed 12 years ago by Jeroen Demeyer

Status: needs_workpositive_review

Due to a mistake by me (confusing #9838 with #9893), this ticket did not get merged in sage-4.6.1.alpha0.

comment:13 Changed 12 years ago by Daniel Bump

The ticket is still described as resolved:fixed.

I don't think I can revert the fixed status: trac admin has to do that. (It doesn't matter if this won't cause the release manager to forget the patch.)

comment:14 Changed 12 years ago by Minh Van Nguyen

Status: positive_reviewclosed

comment:15 Changed 12 years ago by Minh Van Nguyen

Resolution: fixed
Status: closednew

comment:16 Changed 12 years ago by Minh Van Nguyen

Status: newneeds_review

comment:17 Changed 12 years ago by Minh Van Nguyen

Status: needs_reviewpositive_review

comment:18 in reply to:  13 Changed 12 years ago by Minh Van Nguyen

Replying to bump:

I don't think I can revert the fixed status: trac admin has to do that.

Done.

comment:19 Changed 12 years ago by Jeroen Demeyer

Merged in: sage-4.6.1.alpha1
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.