Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#9836 closed enhancement (fixed)

Linear Programming Thematic Tutorial

Reported by: ncohen Owned by: mvngu
Priority: major Milestone: sage-4.6
Component: documentation Keywords:
Cc: minh, rhinton Merged in: sage-4.6.alpha1
Authors: Nathann Cohen Reviewers: Minh Van Nguyen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by mpatel)

Here it is ! The long-promised tutorial for LP. It is a translation of the french sagebook, and I hope I will be able to keep the two coordinated :-)

This patchremoved the old tutorial from the "constructions" document where it shouldn't have been put in the first place, and creates a new file in thematic_tutorials. It is up-to-date for the moment, though I hope to be able to work on some improvements with the CPLEX interface soon. It may only change te way CPLEX has to be installed, which would only require a minor edit later.

Apply:

  1. trac_9836.patch
  2. trac_9836-reviewer.patch
  3. trac_9836 - renaming a variable.patch
  4. trac_9836-manifest.patch

Attachments (6)

lp_flot1.png (53.9 KB) - added by ncohen 8 years ago.
lp_flot2.png (61.2 KB) - added by ncohen 8 years ago.
trac_9836.patch (25.0 KB) - added by ncohen 8 years ago.
trac_9836-reviewer.patch (169.3 KB) - added by mvngu 8 years ago.
trac_9836 - renaming a variable.patch (1.2 KB) - added by ncohen 8 years ago.
trac_9836-manifest.patch (758 bytes) - added by mpatel 8 years ago.
Add new .png files to MANIFEST.in

Download all attachments as: .zip

Change History (15)

Changed 8 years ago by ncohen

Changed 8 years ago by ncohen

comment:1 Changed 8 years ago by ncohen

  • Status changed from new to needs_work

The two pictures should be added to the thematic_tutotials/ folder. This patch does not pass doctests for two reasons :

  • Sage forgets the definition of the variables between different code sections (if you have any idea about how to fix this ^^;)
  • There is a random doctest which should fail every second run, but it is a bit hard to fix with all the previous errors

Sorry to send this patch like that. This may be the last time I can access internet before next week (and I incidentally skipped my second meal today to finish it :-D), so if somebody knows how to fix these.. Otherwise, I'll take care of it when I'm back :-)

Nathann

comment:2 Changed 8 years ago by ncohen

  • Status changed from needs_work to needs_review

Changed 8 years ago by ncohen

Changed 8 years ago by mvngu

comment:3 Changed 8 years ago by mvngu

  • Authors set to Nathann Cohen
  • Description modified (diff)
  • Reviewers set to Minh Van Nguyen

I'm happy with ncohen's tutorial. I have attached a reviewer patch to make it slightly better. Changes include:

  • Directly add the two images with hg add. This makes sure that the images are under revision control.
  • Where possible, cut off lines at about 75 characters.
  • Some consistency in how you space headings.
  • Some consistency in how you present Sage code.
  • Use 4 space indentation.
  • Numerous typo fixes.
  • Simplify some of the prose to suit a tutorial format.

I need another pair of eyes to check my patch.

comment:4 Changed 8 years ago by ncohen

Thank you for your patch Minh ! I noticed reviewing it that I had forgotten to rename a variable, "poids", which means "weight" in french :-D

Could you check this small patch before changing this ticket's status ?

Thanks !

Nathann

Changed 8 years ago by ncohen

comment:5 Changed 8 years ago by ncohen

  • Description modified (diff)

comment:6 Changed 8 years ago by ncohen

  • Description modified (diff)

comment:7 Changed 8 years ago by mvngu

  • Status changed from needs_review to positive_review

Good! Let's get it into the standard documentation.

comment:8 Changed 8 years ago by mpatel

  • Merged in set to sage-4.6.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed

Changed 8 years ago by mpatel

Add new .png files to MANIFEST.in

comment:9 Changed 8 years ago by mpatel

  • Description modified (diff)

I've attached a patch that fixes two Sphinx warnings:

/mnt/usb1/scratch/mpatel/tmp/sage-4.6.alpha1/devel/sage/doc/en/thematic_tutorials/linear_programming.rst:: WARNING: image file not readable: static/lp_flot1.png
/mnt/usb1/scratch/mpatel/tmp/sage-4.6.alpha1/devel/sage/doc/en/thematic_tutorials/linear_programming.rst:: WARNING: image file not readable: static/lp_flot2.png
Note: See TracTickets for help on using tickets.