#9836 closed enhancement (fixed)
Linear Programming Thematic Tutorial
| Reported by: | Nathann Cohen | Owned by: | Minh Van Nguyen |
|---|---|---|---|
| Priority: | major | Milestone: | sage-4.6 |
| Component: | documentation | Keywords: | |
| Cc: | minh, Ryan Hinton | Merged in: | sage-4.6.alpha1 |
| Authors: | Nathann Cohen | Reviewers: | Minh Van Nguyen |
| Report Upstream: | N/A | Work issues: | |
| Branch: | Commit: | ||
| Dependencies: | Stopgaps: |
Status badges
Description (last modified by )
Here it is ! The long-promised tutorial for LP. It is a translation of the french sagebook, and I hope I will be able to keep the two coordinated :-)
This patchremoved the old tutorial from the "constructions" document where it shouldn't have been put in the first place, and creates a new file in thematic_tutorials. It is up-to-date for the moment, though I hope to be able to work on some improvements with the CPLEX interface soon. It may only change te way CPLEX has to be installed, which would only require a minor edit later.
Apply:
Attachments (6)
Change History (15)
Changed 12 years ago by
| Attachment: | lp_flot1.png added |
|---|
Changed 12 years ago by
| Attachment: | lp_flot2.png added |
|---|
comment:1 Changed 12 years ago by
| Status: | new → needs_work |
|---|
comment:2 Changed 12 years ago by
| Status: | needs_work → needs_review |
|---|
Updated thanks to wise advice :-)
It is now ready for review !
Nathann
Changed 12 years ago by
| Attachment: | trac_9836.patch added |
|---|
Changed 12 years ago by
| Attachment: | trac_9836-reviewer.patch added |
|---|
comment:3 Changed 12 years ago by
| Authors: | → Nathann Cohen |
|---|---|
| Description: | modified (diff) |
| Reviewers: | → Minh Van Nguyen |
I'm happy with ncohen's tutorial. I have attached a reviewer patch to make it slightly better. Changes include:
- Directly add the two images with
hg add. This makes sure that the images are under revision control. - Where possible, cut off lines at about 75 characters.
- Some consistency in how you space headings.
- Some consistency in how you present Sage code.
- Use 4 space indentation.
- Numerous typo fixes.
- Simplify some of the prose to suit a tutorial format.
I need another pair of eyes to check my patch.
comment:4 Changed 12 years ago by
Thank you for your patch Minh ! I noticed reviewing it that I had forgotten to rename a variable, "poids", which means "weight" in french :-D
Could you check this small patch before changing this ticket's status ?
Thanks !
Nathann
Changed 12 years ago by
| Attachment: | trac_9836 - renaming a variable.patch added |
|---|
comment:5 Changed 12 years ago by
| Description: | modified (diff) |
|---|
comment:6 Changed 12 years ago by
| Description: | modified (diff) |
|---|
comment:7 Changed 12 years ago by
| Status: | needs_review → positive_review |
|---|
Good! Let's get it into the standard documentation.
comment:8 Changed 12 years ago by
| Merged in: | → sage-4.6.alpha1 |
|---|---|
| Resolution: | → fixed |
| Status: | positive_review → closed |
Changed 12 years ago by
| Attachment: | trac_9836-manifest.patch added |
|---|
Add new .png files to MANIFEST.in
comment:9 Changed 12 years ago by
| Description: | modified (diff) |
|---|
I've attached a patch that fixes two Sphinx warnings:
/mnt/usb1/scratch/mpatel/tmp/sage-4.6.alpha1/devel/sage/doc/en/thematic_tutorials/linear_programming.rst:: WARNING: image file not readable: static/lp_flot1.png /mnt/usb1/scratch/mpatel/tmp/sage-4.6.alpha1/devel/sage/doc/en/thematic_tutorials/linear_programming.rst:: WARNING: image file not readable: static/lp_flot2.png
The two pictures should be added to the
thematic_tutotials/folder. This patch does not pass doctests for two reasons :^^;)Sorry to send this patch like that. This may be the last time I can access internet before next week (and I incidentally skipped my second meal today to finish it
:-D), so if somebody knows how to fix these.. Otherwise, I'll take care of it when I'm back:-)Nathann