#9828 closed enhancement (fixed)
Upgrade to Cython 0.13
Reported by: | mpatel | Owned by: | tbd |
---|---|---|---|
Priority: | major | Milestone: | sage-4.6 |
Component: | packages: standard | Keywords: | |
Cc: | robertwb, leif, jason, craigcitro, timdumol, mpatel | Merged in: | sage-4.6.alpha3 |
Authors: | Robert Bradshaw, Craig Citro, Leif Leonhardy | Reviewers: | Jason Grout, Leif Leonhardy, Mitesh Patel |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
Here are the release notes for Cython 0.13.
Apply
- http://sage.math.washington.edu/home/mpatel/trac/10036/sagenb-0.8.5.spkg (#10036's SageNB 0.8.5 package).
- trac_9828-cython_0_13.patch to the sage repository.
- trac_9828-scripts_hudson.patch to the scripts repository.
Attachments (15)
Change History (59)
comment:1 Changed 11 years ago by
- Cc leif added
comment:2 Changed 11 years ago by
comment:3 Changed 11 years ago by
I get the same when trying to reinstall sage-4.6.alpha0.spkg
, or afterwards again running ./sage -ba
.
comment:4 Changed 11 years ago by
From the release notes:
"More shipped standard library declarations. The
python_*
andstdlib/stdio .pxd
files have been deprecated in favor ofclib.*
andcpython[.*]
and may get removed in a future release. "
comment:5 follow-up: ↓ 6 Changed 11 years ago by
Did you apply the 8 Sage library patches mentioned in this sage-devel thread?
Disclaimer: I haven't checked whether all of these patches are necessary and sufficient for Cython 0.13 final.
comment:6 in reply to: ↑ 5 Changed 11 years ago by
Replying to mpatel:
Did you apply the 8 Sage library patches mentioned in this sage-devel thread?
No (I haven't read that thread), I just tried and looked what happens... :)
I've created symbolic links to the pxds in the Deprecated/
directory and now run (at least) into the missing from cpython import bool
problem.
I would have expected some more info / notes here or at the Cython site; Volker Braun asked on the IRC when Cython will get updated (I knew there was 0.12.2 and a new release coming up), so I took a look at this ticket.
comment:7 Changed 11 years ago by
I've got an 0.13 spkg that has a tiny patch on top to fix the performance regression with __getattr__
. Yes, you need to appply all 8 Sage library patches, though I plan to clean at least one of them up 'cause it's got unnecessary garbage in it. (I was actually working on this last night, and planned to finish it up tonight.)
comment:8 Changed 11 years ago by
- Cc jason added
comment:9 Changed 11 years ago by
Spkg up at http://sage.math.washington.edu/home/robertwb/cython/cython-0.13.p0.spkg . I'm attaching a set of patches that should be necessary and sufficient.
Changed 11 years ago by
Changed 11 years ago by
Changed 11 years ago by
Changed 11 years ago by
Changed 11 years ago by
Changed 11 years ago by
Changed 11 years ago by
Changed 11 years ago by
comment:10 Changed 11 years ago by
- Status changed from new to needs_review
The last one, hudson_results.patch, isn't needed for Sage but makes continuous testing of Sage against cython-devel much easier.
comment:11 Changed 11 years ago by
- Description modified (diff)
comment:12 Changed 11 years ago by
spkg-install
and SPKG.txt
(Changelog!) need little clean-up. (I made my own spkg yesterday, so I could carry the changes over.)
comment:13 follow-up: ↓ 14 Changed 11 years ago by
- Cc craigcitro added
Feel free to carry your changes over. SPKG.txt doesn't have a changelog because it's all in the revision control and there's very little to say anyways (other than "bumped revision" which is pretty redundant). I'd be happy to review whatever you have.
comment:14 in reply to: ↑ 13 Changed 11 years ago by
Replying to robertwb:
Feel free to carry your changes over.
Ok.
SPKG.txt doesn't have a changelog because it's all in the revision control and there's very little to say anyways (other than "bumped revision" which is pretty redundant).
Well, it wouldn't be bad to see in SPKG.txt which version was packaged when for Sage...
It's of course (at least currently) unlikely that Sage will patch Cython rather than report problems "upstream" and include a (quickly) fixed upstream version.
Hope you'll stay at Sage and Cython... ;-)
comment:15 Changed 11 years ago by
Funny, my patch (also) intended to avoid exactly the error which is currently made in spkg-install
. :D
Coming soon...
comment:16 Changed 11 years ago by
Patch is up.
comment:17 Changed 11 years ago by
Looks fine to me, except that the change was to speed up __getattr__
not __getitem__
(specifically for Python descendants of cdef classes).
comment:18 Changed 11 years ago by
Oooops...
Changed 11 years ago by
SPKG patch. As the name says... (also quotes SAGE_LOCAL; some clean-up) Now with corrected SPKG.txt (getattr).
comment:19 Changed 11 years ago by
I've replaced the patch with a corrected one (__getitem__()
-> __getattr__()
in the changelog).
Changed 11 years ago by
comment:20 Changed 11 years ago by
Okay, now I'm really confused about what patches I should apply where to review this. Can someone give directions for reviewing? Thanks!
comment:21 Changed 11 years ago by
Thanks for being willing to take a look. Apply patches 0-7 and hudson_results.patch to the sage library in order. I have incorporated trac_9828-fix_applying_patch_and_more-spkg.patch into the spkg (at the same address as above). sage-local-hudson.patch gets applied to sage/local/bin. If you have any other questions, please don't hesitate to ask.
comment:22 Changed 11 years ago by
- Status changed from needs_review to needs_work
Hmmm, patches still apply (without rejects) to Sage 4.6.alpha2[pre2], spkg installs ok, and ./sage -b
also works.
But after that, Sage doesn't start (Sphinx raises the same exception):
... Testing that Sage starts... Traceback (most recent call last): File "/home/leif/Sage/sage-4.6.alpha2pre2/local/bin/sage-eval", line 4, in <module> from sage.all import * File "/home/leif/Sage/sage-4.6.alpha2pre2/local/lib/python2.6/site-packages/sage/all.py", line 64, in <module> from sage.misc.all import * # takes a while File "/home/leif/Sage/sage-4.6.alpha2pre2/local/lib/python2.6/site-packages/sage/misc/all.py", line 67, in <module> from sage_input import sage_input File "/home/leif/Sage/sage-4.6.alpha2pre2/local/lib/python2.6/site-packages/sage/misc/sage_input.py", line 163, in <module> from sage.misc.functional import parent File "/home/leif/Sage/sage-4.6.alpha2pre2/local/lib/python2.6/site-packages/sage/misc/functional.py", line 34, in <module> import sage.interfaces.expect File "/home/leif/Sage/sage-4.6.alpha2pre2/local/lib/python2.6/site-packages/sage/interfaces/expect.py", line 52, in <module> from sage.structure.parent_base import ParentWithBase File "parent_base.pyx", line 1, in init sage.structure.parent_base (sage/structure/parent_base.c:1934) File "parent_old.pyx", line 1, in init sage.structure.parent_old (sage/structure/parent_old.c:7031) File "parent.pyx", line 383, in init sage.structure.parent (sage/structure/parent.c:20048) AttributeError: type object 'sage.structure.parent.Parent' has no attribute '__getattr__' Sage failed to startup. make: *** [ptestlong] Error 1
./sage -ba
(tried after that) doesn't work either, due to newly merged Cython code:
*** TOUCHING ALL CYTHON (.pyx) FILES *** scons: `install' is up to date. ---------------------------------------------------------- sage: Building and installing modified Sage library files. Installing c_lib scons: `install' is up to date. Updating Cython code.... Building modified file sage/algebras/quatalg/quaternion_algebra_element.pyx. Building modified file sage/algebras/quatalg/quaternion_algebra_cython.pyx. Building modified file sage/calculus/var.pyx. ... Building modified file sage/ext/interpreters/wrapper_rr.pyx. Building modified file sage/ext/interpreters/wrapper_py.pyx. Building modified file sage/ext/interpreters/wrapper_el.pyx. Execute 271 commands (using 8 threads) Error converting Pyrex file to C: ------------------------------------------------------------ ... cdef int *vertices cdef int **line_h_out cdef int **line_h_in cdef list g_vertices cdef int i cdef bool directed ^ ------------------------------------------------------------ /home/leif/Sage/sage-4.6.alpha2pre2/devel/sage-9828-cython/sage/graphs/generic_graph_pyx.pxd:26:9: 'bool' is not a type identifier ... python `which cython` --embed-positions --directive cdivision=True,autotestdict=False -I/home/leif/Sage/sage-4.6.alpha2pre2/devel/sage-9828-cython -o sage/gsl/callback.c sage/gsl/callback.pyx sage/gsl/callback.pyx --> /home/leif/Sage/sage-4.6.alpha2pre2/local//lib/python/site-packages//sage/gsl/callback.pyx python `which cython` --embed-positions --directive cdivision=True,autotestdictwarning: /home/leif/Sage/sage-4.6.alpha2pre2/devel/sage-9828-cython/sage/gsl/gsl_array.pyx:1:0: __getslice__, __setslice__, and __delslice__ are not supported by Python 3, use __getitem__, __setitem__, and __delitem__ instead warning: /home/leif/Sage/sage-4.6.alpha2pre2/devel/sage-9828-cython/sage/gsl/fft.pyx:1:0: __getslice__, __setslice__, and __delslice__ are not supported by Python 3, use __getitem__, __setitem__, and __delitem__ instead Error running command, failed with status 256. sage: There was an error installing modified sage library code.
comment:23 follow-up: ↓ 24 Changed 11 years ago by
Looks like a bool->bint was missed?
comment:24 in reply to: ↑ 23 Changed 11 years ago by
Replying to jason:
Looks like a bool->bint was missed?
Or added since this spkg was created--it used to all work fine. I suppose I'll download the latest alpha and see what's up.
Changed 11 years ago by
comment:25 Changed 11 years ago by
- Description modified (diff)
- Status changed from needs_work to needs_review
OK, one more patch, and an updated spkg.
comment:26 Changed 11 years ago by
I see Craig is the author of a lot of the patches. robertwb: have you reviewed those patches? Which patches still need review?
I applied all patches and installed on a fresh copy of 4.6.alpha2 (I think it's a fresh copy), and had the following failures in ptestlong on Ubuntu 10.04 64-bit:
File "/home/grout/sage-4.6.alpha2/devel/sage-main/sage/misc/sageinspect.py", line 1058: sage: sage_getdef(sage.rings.integer.Integer.__init__, obj_name='__init__') Expected: '__init__(x=None, base=0)' Got: '__init__( [noargspec] )'
(that's a test that I thought one of the patches changed to the expected value listed above).
sage -t -long 4.6.alpha2/devel/sage/sage/plot/misc.py # 4 doctests failed sage -t -long 4.6.alpha2/devel/sage/sage/plot/plot.py # 12 doctests failed
These are corrected in #9221, I think.
comment:27 follow-up: ↓ 28 Changed 11 years ago by
I've looked at all of the ones Craig wrote (way back) and they're all fine. I assume you did a sage -ba after installing Cython? The sageinspect output is what I got on a fresh 4.6.alpha2 on sage.math. I doubt the plot ones are related, but I didn't see them when I ran the tests which is strange.
comment:28 in reply to: ↑ 27 Changed 11 years ago by
Replying to robertwb:
I've looked at all of the ones Craig wrote (way back) and they're all fine. I assume you did a sage -ba after installing Cython? The sageinspect output is what I got on a fresh 4.6.alpha2 on sage.math. I doubt the plot ones are related, but I didn't see them when I ran the tests which is strange.
I didn't do sage -ba. I'm trying again now.
comment:29 Changed 11 years ago by
I did sage -ba (4.6.alpha2, the above patches applied, and the new Cython spkg), and still got the following failures (Ubuntu 10.04 64-bit):
sage -t -long local/lib/python2.6/site-packages/sagenb-0.8.2-py2.6.egg/sagenb/misc/sageinspect.py ********************************************************************** File "/home/grout/sage-4.6.alpha2/local/lib/python2.6/site-packages/sagenb-0.8.2-py2.6.egg/sagenb/misc/sageinspect.py", line 1074: sage: sage_getsource(sage.rings.integer.Integer.__init__, is_binary=True) Expected: Traceback (most recent call last): ... TypeError: arg is not a module, class, method, function, traceback, frame, or code objectGot: ' def __init__(self, x=None, unsigned int base=0):\n """\n EXAMPLES::\n \n sage: a = long(-901824309821093821093812093810928309183091832091)\n sage: b = ZZ(a); b\n -901824309821093821093812093810928309183091832091\n sage: ZZ(b)\n -901824309821093821093812093810928309183091832091\n sage: ZZ(\'-901824309821093821093812093810928309183091832091\')\n -901824309821093821093812093810928309183091832091\n sage: ZZ(int(-93820984323))\n -93820984323\n sage: ZZ(ZZ(-901824309821093821093812093810928309183091832091))\n -901824309821093821093812093810928309183091832091\n sage: ZZ(QQ(-901824309821093821093812093810928309183091832091))\n -901824309821093821093812093810928309183091832091\n sage: ZZ(RR(2.0)^80)\n 1208925819614629174706176\n sage: ZZ(QQbar(sqrt(28-10*sqrt(3)) + sqrt(3)))\n 5\n sage: ZZ(AA(32).nth_root(5))\n 2\n sage: ZZ(pari(\'Mod(-3,7)\'))\n 4\n sage: ZZ(\'sage\')\n Traceback (most recent call last):\n ...\n TypeError: unable to convert x (=sage) to an integer\n sage: Integer(\'zz\',36).str(36)\n \'zz\'\n sage: ZZ(\'0x3b\').str(16)\n \'3b\'\n sage: ZZ( ZZ(5).digits(3) , 3)\n 5\n sage: import numpy\n sage: ZZ(numpy.int64(7^7))\n 823543\n sage: ZZ(numpy.ubyte(-7))\n 249\n sage: ZZ(True)\n 1\n sage: ZZ(False)\n 0\n sage: ZZ(1==0)\n 0\n sage: ZZ(\'+10\')\n 10\n \n ::\n \n sage: k = GF(2)\n sage: ZZ( (k(0),k(1)), 2)\n 2\n \n ::\n \n sage: t = pari(0*ZZ[x].0 + 3)\n sage: t.type()\n \'t_POL\'\n sage: ZZ(t)\n 3\n\n sage: ZZ(float(2.0))\n 2\n sage: ZZ(float(1.0/0.0))\n Traceback (most recent call last):\n ...\n OverflowError: cannot convert float infinity to integer\n sage: ZZ(float(0.0/0.0))\n Traceback (most recent call last):\n ...\n ValueError: cannot convert float NaN to integer\n\n ::\n\n sage: class MyInt(int):\n ... pass\n sage: class MyLong(long):\n ... pass\n sage: class MyFloat(float):\n ... pass\n sage: ZZ(MyInt(3))\n 3\n sage: ZZ(MyLong(4))\n 4\n sage: ZZ(MyFloat(5))\n 5\n """\n\n # TODO: All the code below should somehow be in an external\n # cdef\'d function. Then e.g., if a matrix or vector or\n # polynomial is getting filled by mpz_t\'s, it can use the\n # rules below to do the fill construction of mpz_t\'s, but\n # without the overhead of creating any Python objects at all.\n # The cdef\'s function should be of the form\n # mpz_init_set_sage(mpz_t y, object x)\n # Then this function becomes the one liner:\n # mpz_init_set_sage(self.value, x)\n\n cdef Integer tmp\n cdef char* xs\n \n cdef Element lift\n \n if x is None:\n if mpz_sgn(self.value) != 0:\n mpz_set_si(self.value, 0)\n \n else:\n # First do all the type-check versions; these are fast.\n\n if PY_TYPE_CHECK(x, Integer):\n set_from_Integer(self, <Integer>x)\n\n elif PY_TYPE_CHECK(x, bool):\n mpz_set_si(self.value, PyInt_AS_LONG(x))\n\n elif PyInt_Check(x):\n mpz_set_si(self.value, PyInt_AS_LONG(x))\n\n elif PyLong_Check(x):\n mpz_set_pylong(self.value, x)\n\n elif PyFloat_Check(x):\n n = long(x)\n if n == x:\n mpz_set_pylong(self.value, n)\n else:\n raise TypeError, "Cannot convert non-integral float to integer"\n\n elif PY_TYPE_CHECK(x, pari_gen):\n \n if typ((<pari_gen>x).g) == t_INT:\n t_INT_to_ZZ(self.value, (<pari_gen>x).g)\n \n else:\n if typ((<pari_gen>x).g) == t_INTMOD:\n x = x.lift()\n # TODO: figure out how to convert to pari integer in base 16 ?\n \n # todo: having this "s" variable around here is causing\n # Cython to play games with refcount for the None object, which\n # seems really stupid.\n \n try:\n s = hex(x)\n base = 16\n except:\n s = str(x)\n base = 10\n \n if mpz_set_str(self.value, s, base) != 0:\n raise TypeError, "Unable to coerce PARI %s to an Integer."%x\n\n elif PyString_Check(x):\n if base < 0 or base > 36:\n raise ValueError, "base (=%s) must be between 2 and 36"%base\n \n xs = x\n if xs[0] == c\'+\':\n xs += 1\n if mpz_set_str(self.value, xs, base) != 0:\n raise TypeError, "unable to convert x (=%s) to an integer"%x\n \n elif PyObject_HasAttrString(x, "_integer_"):\n # todo: Note that PyObject_GetAttrString returns NULL if\n # the attribute was not found. If we could test for this,\n # we could skip the double lookup. Unfortunately Cython doesn\'t\n # seem to let us do this; it flags an error if the function\n # returns NULL, because it can\'t construct an "object" object\n # out of the NULL pointer. This really sucks. Perhaps we could\n # make the function prototype have return type void*, but\n # then how do we make Cython handle the reference counting?\n set_from_Integer(self, (<object> PyObject_GetAttrString(x, "_integer_"))(the_integer_ring))\n\n elif (PY_TYPE_CHECK(x, list) or PY_TYPE_CHECK(x, tuple)) and base > 1:\n b = the_integer_ring(base)\n tmp = the_integer_ring(0)\n for i in range(len(x)):\n tmp += t he_integer_ring(x[i])*b**i\n mpz_set(self.value, tmp.value)\n\n else:\n import numpy\n if isinstance(x, numpy.integer):\n mpz_set_p ylong(self.value, x.__long__())\n return\n \n elif PY_TYPE_CHECK(x, Element):\n try:\n lift = x.lift()\n if lift._parent != (<Element>x)._parent:\n tmp = the_integer_ring(lift)\n mpz_swap(tmp.value, self.value)\n return\n except AttributeError:\n pass\n \n raise TypeError, "unable to coerce %s to an integer" % type(x)\n' ********************************************************************** File "/home/grout/sage-4.6.alpha2/local/lib/python2.6/site-packages/sagenb-0.8.2-py2.6.egg/sagenb/misc/sageinspect.py", line 1079: sage: sage_getdef(sage.rings.integer.Integer.__init__, obj_name='__init__') Expected: '__init__( [noargspec] )' Got: '__init__(x=None, base=0)' ********************************************************************** 1 items had failures: 2 of 26 in __main__.example_23 ***Test Failed*** 2 failures.
comment:30 follow-up: ↓ 31 Changed 11 years ago by
- Cc timdumol mpatel added
I just noticed those two failures were in sagenb. I can replicate them doing sage -t -sagenb
. It looks like the same changes that were needed in sage/misc/sageinspect.py are also needed in the notebook version of that file? (see the 8_alpha_fixes.patch above).
I'm not sure how the two sageinspect.py files are related (in the library and in the notebook), so I'm CCing Tim and Mitesh on this.
comment:31 in reply to: ↑ 30 ; follow-up: ↓ 32 Changed 11 years ago by
Replying to jason:
I just noticed those two failures were in sagenb. I can replicate them doing
sage -t -sagenb
. It looks like the same changes that were needed in sage/misc/sageinspect.py are also needed in the notebook version of that file? (see the 8_alpha_fixes.patch above).I'm not sure how the two sageinspect.py files are related (in the library and in the notebook), so I'm CCing Tim and Mitesh on this.
The sageinspect.py
in SageNB was derived from the sageinspect.py
of the main Sage library by William when the new SageNB was separated from the main Sage library. Feel free to make the same changes.
comment:32 in reply to: ↑ 31 ; follow-up: ↓ 33 Changed 11 years ago by
Replying to timdumol:
Replying to jason:
I just noticed those two failures were in sagenb. I can replicate them doing
sage -t -sagenb
. It looks like the same changes that were needed in sage/misc/sageinspect.py are also needed in the notebook version of that file? (see the 8_alpha_fixes.patch above).I'm not sure how the two sageinspect.py files are related (in the library and in the notebook), so I'm CCing Tim and Mitesh on this.
The
sageinspect.py
in SageNB was derived from thesageinspect.py
of the main Sage library by William when the new SageNB was separated from the main Sage library. Feel free to make the same changes.
Is there any reason why it is not just imported, rather than being copied?
comment:33 in reply to: ↑ 32 Changed 11 years ago by
Replying to jason:
Replying to timdumol:
Replying to jason:
I just noticed those two failures were in sagenb. I can replicate them doing
sage -t -sagenb
. It looks like the same changes that were needed in sage/misc/sageinspect.py are also needed in the notebook version of that file? (see the 8_alpha_fixes.patch above).I'm not sure how the two sageinspect.py files are related (in the library and in the notebook), so I'm CCing Tim and Mitesh on this.
The
sageinspect.py
in SageNB was derived from thesageinspect.py
of the main Sage library by William when the new SageNB was separated from the main Sage library. Feel free to make the same changes.Is there any reason why it is not just imported, rather than being copied?
William stated that he wanted SageNB to be usable separately from Sage, which means not having to import Sage libraries to function.
comment:34 follow-up: ↓ 35 Changed 11 years ago by
Yes, the sagenb version needs to be updated as well. Should I post a new sagenb spkg, or is there one already in the works?
Anything else?
comment:35 in reply to: ↑ 34 Changed 11 years ago by
comment:36 Changed 11 years ago by
Is a SageNB patch the only barrier to a positive review?
Changed 11 years ago by
Ticket number in scripts repo patch. Apply only this patch to the scripts repo.
comment:37 Changed 11 years ago by
- Description modified (diff)
- Milestone set to sage-4.6
- Reviewers set to Jason Grout, Leif Leonhardy, Mitesh Patel
I've added a SageNB patch, folded sage repository patch, and updated scripts repository patch with the ticket number in the commit string. The SageNB package link is in the description
comment:38 follow-ups: ↓ 41 ↓ 42 Changed 11 years ago by
- Status changed from needs_review to positive_review
The long doctests pass for me on sage.math with 4.6.alpha2 + the spkgs and patches in the description.
If no one objects, I'm giving this a positive review. Can someone please review #10036 soon?
By the way, does XML_RESULTS = os.environ.get('XML_RESULTS', None)
internally do the same as
try: XML_RESULTS = os.environ['XML_RESULTS'] except KeyError: XML_RESULTS = None
?
comment:39 Changed 11 years ago by
- Description modified (diff)
comment:40 Changed 11 years ago by
- Merged in set to sage-4.6.alpha3
- Resolution set to fixed
- Status changed from positive_review to closed
comment:41 in reply to: ↑ 38 Changed 11 years ago by
Replying to mpatel:
The long doctests pass for me on sage.math with 4.6.alpha2 + the spkgs and patches in the description.
If no one objects, I'm giving this a positive review. Can someone please review #10036 soon?
By the way, does
XML_RESULTS = os.environ.get('XML_RESULTS', None)
internally do the same astry: XML_RESULTS = os.environ['XML_RESULTS'] except KeyError: XML_RESULTS = None?
Yes. See http://docs.python.org/library/stdtypes.html#dict.get
comment:42 in reply to: ↑ 38 ; follow-up: ↓ 43 Changed 11 years ago by
Replying to mpatel:
The long doctests pass for me on sage.math with 4.6.alpha2 + the spkgs and patches in the description.
If no one objects, I'm giving this a positive review.
Thanks all! Next up, Cython 0.13.1 :) I'm neither planning to wait as long nor make as many changes, so it won't be near as bad...
Can someone please review #10036 soon?
By the way, does
XML_RESULTS = os.environ.get('XML_RESULTS', None)
internally do the same astry: XML_RESULTS = os.environ['XML_RESULTS'] except KeyError: XML_RESULTS = None?
Yes, that would have probably been cleaner.
comment:43 in reply to: ↑ 42 Changed 11 years ago by
Replying to robertwb:
By the way, does
XML_RESULTS = os.environ.get('XML_RESULTS', None)
internally do the same astry: XML_RESULTS = os.environ['XML_RESULTS'] except KeyError: XML_RESULTS = None?
Yes, that would have probably been cleaner.
Since None is the default default value, it could even be shortened to XML_RESULTS = os.environ.get('XML_RESULTS')
comment:44 Changed 3 years ago by
What is the purpose of this XML_RESULTS
stuff which was introduced here?