Opened 12 years ago

Closed 8 years ago

#9827 closed defect (fixed)

Intermittent doctest failure in sage/interfaces/psage.py

Reported by: mpatel Owned by: was
Priority: major Milestone: sage-6.4
Component: interfaces Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 019dda0 (Commits, GitHub, GitLab) Commit: 019dda08c66a4fd4deea44ff5e87714ac2ba3575
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

This happens sometimes: 

sage -t --long devel/sage/sage/interfaces/psage.py
**********************************************************************
File "devel/sage/sage/interfaces/psage.py", line 37, in sage.interfaces.psage
Failed example:
    w       # long time, random output
Exception raised:
    Traceback (most recent call last):
      File "/release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.9.beta4/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 466, in _run
        self.execute(example, compiled, test.globs)
      File "/release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.9.beta4/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 825, in execute
        exec compiled in globs
      File "<doctest sage.interfaces.psage[3]>", line 1, in <module>
        w       # long time, random output
      File "/release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.9.beta4/local/lib/python2.7/site-packages/sage/misc/displayhook.py", line 201, in __call__
        self.oldhook(obj)
      File "/release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.9.beta4/local/lib/python2.7/site-packages/sage/interfaces/interface.py", line 880, in __repr__
        s =  s.replace(self._name, self.__dict__['__custom_name'])
    KeyError: '__custom_name'
**********************************************************************

See ​this reply (and possible follow-ups) for batch-testing results for psage.py.

Distantly related: #1991.

Attachments (1)

9827_custom_name.patch​ (824 bytes) - added by jdemeyer 9 years ago.

Download all attachments as: .zip

Change History (16)

comment:1 Changed 12 years ago by mpatel

Near the top of sage/interfaces/psage.py is a possibly relevant note: 

BUG -- currently non-idle PSage subprocesses do not stop when
\sage exits.  I would very much like to fix this but don't know how.

comment:2 Changed 9 years ago by roed

Is this still relevant after #12415?

comment:3 Changed 9 years ago by roed

  • Component changed from doctest to interfaces
  • Owner changed from mvngu to was

I don't think this has to do with doctesting...

comment:4 Changed 9 years ago by jdemeyer

  • Description modified (diff)
  • Milestone set to sage-5.10

comment:5 Changed 9 years ago by jdemeyer

  • Description modified (diff)

Changed 9 years ago by jdemeyer

comment:6 Changed 9 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Status changed from new to needs_review

comment:7 Changed 9 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:8 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:9 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:10 Changed 8 years ago by ppurka

I too ran into intermittent doctest failures in #12061

comment:11 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:12 Changed 8 years ago by chapoton

  • Branch set to public/9827
  • Commit set to 0c8ae85ed98466fb0fcde477d021c8d9f3b93581

New commits:

​0c8ae85trac #9827 simple fix

comment:13 Changed 8 years ago by git

  • Commit changed from 0c8ae85ed98466fb0fcde477d021c8d9f3b93581 to 019dda08c66a4fd4deea44ff5e87714ac2ba3575

Branch pushed to git repo; I updated commit sha1. New commits:

​019dda0trac #9827 typo

comment:14 Changed 8 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

Looks good to me.

comment:15 Changed 8 years ago by vbraun

  • Branch changed from public/9827 to 019dda08c66a4fd4deea44ff5e87714ac2ba3575
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.