Opened 9 years ago

Closed 9 years ago

#9813 closed enhancement (fixed)

parametric plot and polar plot aspect ratio

Reported by: jason Owned by: jason, was
Priority: minor Milestone: sage-4.6
Component: graphics Keywords: beginner
Cc: kcrisman, rbeezer Merged in: sage-4.6.alpha1
Authors: Jason Grout Reviewers: Dan Drake
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jason)

I think parametric_plot and polar_plot should default to having an aspect ratio of 1. Often we are plotting circles or other objects where we actually want to see the relationship between the two variables.

In my tests, mma also gives an aspect_ratio of 1 for these sorts of plots.

Attachments (2)

trac-9813-parametric-aspect.patch (3.0 KB) - added by jason 9 years ago.
trac_9813_reviewer.patch (744 bytes) - added by ddrake 9 years ago.
tiny reviewer patch

Download all attachments as: .zip

Change History (10)

comment:1 Changed 9 years ago by jason

  • Keywords beginner added

comment:2 Changed 9 years ago by jason

  • Cc kcrisman rbeezer added
  • Priority changed from major to minor
  • Status changed from new to needs_review

comment:3 Changed 9 years ago by kcrisman

Unfortunately I won't be reviewing much until I switch to wireless, or the semester proves easy... but I would point out that Minh has done some work trying to make sure we are unified in whether it's 2D or 2d or whatever. I feel like his p.o.v. was 2D. Look at things like disk.py or circle.py, where I believe this came into play when I upgraded the docs last year.

comment:4 Changed 9 years ago by kcrisman

Oh, and I should point out that I expect this patch will work as advertised! Code and examples seem straightforward. By the way, somewhere in the developer guide it should say that you need extra lines after plots for them to show up in the live doc - I didn't know that until quite recently, probably courtesy of you.

Changed 9 years ago by jason

comment:5 Changed 9 years ago by jason

  • Description modified (diff)
  • Summary changed from parametric plot aspect ratio to parametric plot and polar plot aspect ratio

Changed 9 years ago by ddrake

tiny reviewer patch

comment:6 Changed 9 years ago by ddrake

  • Authors set to Jason Grout
  • Reviewers set to Dan Drake
  • Status changed from needs_review to positive_review

Looks good. I've added a little reviewer patch that adds in hyperlinks for the polar_plot docstring.

comment:8 Changed 9 years ago by mpatel

  • Merged in set to sage-4.6.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.