Opened 9 years ago

Last modified 8 years ago

#9811 closed defect

sage exits with 0, even if it is unable to install a package. — at Version 2

Reported by: drkirkby Owned by: GeorgSWeber
Priority: major Milestone: sage-4.7.2
Component: scripts Keywords: sage-sage return code status pipestatus tee
Cc: leif, mpatel, jhpalmieri Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by drkirkby)

I wanted to do some testing of Sage in a loop and would check the return code to see if what I used worked or not. But this is impossible, as Sage appears to exit with 0, even if it should not have. In the example below, I try to install a non-existent package using Sage. The return code in a case like this should be non-zero, but it is not.

drkirkby@hawk:~/sage-4.5.2$ ./sage -f some-non-existant-package
Force installing some-non-existant-package
Calling sage-spkg on some-non-existant-package
Warning: Attempted to overwrite SAGE_ROOT environment variable
Building Sage on Solaris in 64-bit mode
Creating SAGE_LOCAL/lib/sage-64.txt since it does not exist
Detected SAGE64 flag
Building Sage on Solaris in 64-bit mode
some-non-existant-package
Machine:
SunOS hawk 5.11 snv_134 i86pc i386 i86pc
Deleting directories from past builds of previous/current versions of some-non-existant-package
/export/home/drkirkby/sage-4.5.2/local/bin/sage-spkg: file some-non-existant-package does not exist
Attempting to download it.
http://www.sagemath.org//packages/optional/some-non-existant-package.spkg --> some-non-existant-package.spkg
[ ]
http://www.sagemath.org//packages/standard/some-non-existant-package.spkg --> some-non-existant-package.spkg
[ ]
http://www.sagemath.org//packages/experimental/some-non-existant-package.spkg --> some-non-existant-package.spkg
[ ]
http://www.sagemath.org//packages/archive/some-non-existant-package.spkg --> some-non-existant-package.spkg
[ ]
**********************************************************************
* Unable to download some-non-existant-package
* Please see http://www.sagemath.org//packages for a list of valid
* packages or check the package name.
**********************************************************************
sage: Failed to download package some-non-existant-package from http://www.sagemath.org/
drkirkby@hawk:~/sage-4.5.2$ $?
bash: 0: command not found
drkirkby@hawk:~/sage-4.5.2$ 

The same happens if one uses sage -i to install a package. If it fails, the exit code is still 0.

In contrast, if I try this with a well written command like ls

drkirkby@hawk:~/sage-4.5.2$ ls some-non-existant-package
some-non-existant-package: No such file or directory
drkirkby@hawk:~/sage-4.5.2$ $?
bash: 2: command not found

the exit code is non-zero - in this case 2.

Also on a similar theme is #9799, showing that make can exit with the wrong code too.

Change History (2)

comment:1 in reply to: ↑ description ; follow-up: Changed 9 years ago by leif

Replying to drkirkby:

drkirkby@hawk:~/sage-4.5.2$ ./sage -f some-non-existant-package
...
drkirkby@hawk:~/sage-4.5.2$ $?
bash: 0: command not found
drkirkby@hawk:~/sage-4.5.2$ 

In contrast, if I try this with a well written command like ls [...] the exit code is non-zero - in this case 2.

Well, you did sage -f ... ...

A well written command like rm exits with a zero status if you use -f:

leif@quadriga:~/Sage/spkgs/mpir-2.1.1$ rm -f non-existent-package ; echo $?
0

I wonder what Sage returns if you do sage -i ... instead... ;-)

Btw, sage-spkg has lots of other flaws. I'm considering writing (and using) my own version, since I doubt the bunch of changes I aim at would get merged soon... (Same for the top-level Makefile, which by the way was named makefile, I guess by some DOS programmer.)

Hopefully not too many people read our tickets... :D

comment:2 in reply to: ↑ 1 Changed 9 years ago by drkirkby

  • Description modified (diff)

Replying to leif:

Well, you did sage -f ... ... I wonder what Sage returns if you do sage -i ... instead... ;-)

The Sage. It still exits with an exit code of zero.

Btw, sage-spkg has lots of other flaws. I'm considering writing (and using) my own version, since I doubt the bunch of changes I aim at would get merged soon... (Same for the top-level Makefile, which by the way was named makefile, I guess by some DOS programmer.)

Hopefully not too many people read our tickets... :D

More, should I think.

Dave

Note: See TracTickets for help on using tickets.