Opened 10 years ago

Closed 10 years ago

#9804 closed defect (fixed)

Remove unnecessary dependency for cliquer in spkg/standard/deps

Reported by: drkirkby Owned by: GeorgSWeber
Priority: minor Milestone: sage-4.6
Component: build Keywords:
Cc: mvngu, mpatel, ncohen Merged in: sage-4.6.alpha1
Authors: David Kirkby Reviewers: Leif Leonhardy
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by leif)

Cliquer used to use SCons, but for various reasons it was replaced by a simple Makefile. (IMHO, a good idea, as fighting with SCons seems to be a nightmare). Minh did the replacement, but there is an unnecessary dependency in spkg/standard/deps, which potentially means parallel builds are slower than they need be, as currently cliquer can't be built without SCons first being built.

See

​http://groups.google.com/group/sage-devel/browse_thread/thread/b4b3cd38f7c5e473/1bfcc79ef1e721dc?q=cliquer+scons+group:sage-devel#1bfcc79ef1e721dc

See also #6681 and #7057.

Dave

Attachments (2)

deps​ (18.2 KB) - added by drkirkby 10 years ago.
Replacement deps, which removes SCONS dependency
deps.diff​ (411 bytes) - added by drkirkby 10 years ago.
Unified diff file for spkg/standard/deps. Relative to 'deps' in sage-4.5.3.alpha2

Download all attachments as: .zip

Change History (9)

Changed 10 years ago by drkirkby

Replacement deps, which removes SCONS dependency

Changed 10 years ago by drkirkby

Unified diff file for spkg/standard/deps. Relative to 'deps' in sage-4.5.3.alpha2

comment:1 Changed 10 years ago by drkirkby

  • Authors set to David Kirkby
  • Cc mvngu mpatel added
  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 Changed 10 years ago by drkirkby

  • Cc mpatel. ncohen added; mpatel removed

I'm adding Nathann Cohen to the CC list, as he is the package maintainer.

comment:3 Changed 10 years ago by leif

  • Cc mpatel added; mpatel. removed
  • Description modified (diff)
  • Summary changed from Remove unnecessary dependy for cliquer in spkg/standard/deps to Remove unnecessary dependency for cliquer in spkg/standard/deps

comment:4 Changed 10 years ago by drkirkby

Can you review it Leif?

Dave

comment:5 Changed 10 years ago by leif

  • Reviewers set to Leif Leonhardy
  • Status changed from needs_review to positive_review

Just for the record: Upstream comes with a Makefile, too (no SConscript).

The attached deps and deps.diff still apply to Sage 4.5.3.rc0.

Positive review.

comment:6 Changed 10 years ago by leif

P.S.: There's a lot wrong with the Cliquer spkg, perhaps to be addressed at #9767.

comment:7 Changed 10 years ago by mpatel

  • Merged in set to sage-4.6.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.