Opened 11 years ago

Closed 10 years ago

#9796 closed enhancement (fixed)

Add a "diagonal" method for matrices

Reported by: jason Owned by: jason, was
Priority: major Milestone: sage-4.6.2
Component: linear algebra Keywords: beginner
Cc: kcrisman Merged in: sage-4.6.2.rc0
Authors: Rob Beezer Reviewers: Tom Coates
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Attachments (1)

trac_9796-matrix-diagonal-elements.patch (1.7 KB) - added by rbeezer 10 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 11 years ago by kcrisman

  • Cc kcrisman added

Changed 10 years ago by rbeezer

comment:2 Changed 10 years ago by rbeezer

  • Keywords beginner added
  • Status changed from new to needs_review

comment:3 follow-up: Changed 10 years ago by tomc

  • Reviewers set to tomc
  • Status changed from needs_review to positive_review

This looks good. Running:

sage -testall -long

gives that all doctests pass except five unrelated tests (in sage/plot/plot3d/tachyon.py and sage/plot/plot3d/base.pyx) that also fail in an unpatched copy of Sage (version 4.6.1, built from source on 64-bit Linux).

comment:4 in reply to: ↑ 3 Changed 10 years ago by rbeezer

Replying to tomc:

Thanks for the review, Tom - the help is appreciated.

Rob

comment:5 follow-up: Changed 10 years ago by kcrisman

  • Authors set to Rob Beezer
  • Reviewers changed from tomc to Tom Coates

I hope it's okay that I 'guessed' the reviewer's name from the trac main page!

comment:6 in reply to: ↑ 5 Changed 10 years ago by jdemeyer

Replying to kcrisman:

I hope it's okay that I 'guessed' the reviewer's name from the trac main page!

I suppose so, I do that all the time.

comment:7 Changed 10 years ago by jdemeyer

  • Merged in set to sage-4.6.2.rc0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.