Opened 11 years ago
Closed 8 years ago
#9772 closed defect (duplicate)
unify doctest commands, especially for 'long' and 'parallel' options
Reported by: | niles | Owned by: | mvngu |
---|---|---|---|
Priority: | major | Milestone: | sage-duplicate/invalid/wontfix |
Component: | doctest coverage | Keywords: | |
Cc: | Merged in: | ||
Authors: | Reviewers: | Jeroen Demeyer | |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
Make sure that the commands for doctesting the entire Sage library test the same files, in particular when including long
and parallel
options.
From William, at
http://ask.sagemath.org/question/35/does-sage-testall-test-long-doctests
Looking at SAGE_ROOT/local/bin/sage-sage
we see that sage -testall
calls the script sage-maketest
which passes all of its options on to sage -t
. [and thus cannot handle a parallel option]
If you look in SAGEROOT/makefile
you'll see that make test
just calls sage-maketest
. Note that make testlong
on the other hand has a specific list of directories it tests, defined in SAGEROOT/makefile
. Right now they match the list in SAGE_ROOT/local/bin/sage-maketest
. However, if these ever get out of sync, bad things will happen in that make test
and make testlong
would suddenly test different code.
Change History (4)
comment:1 Changed 11 years ago by
comment:2 Changed 8 years ago by
- Milestone set to sage-duplicate/invalid/wontfix
- Reviewers set to Jeroen Demeyer
- Status changed from new to needs_review
Superseded by #12415.
comment:3 Changed 8 years ago by
- Status changed from needs_review to positive_review
comment:4 Changed 8 years ago by
- Resolution set to duplicate
- Status changed from positive_review to closed
In fact, there should be a very easy way to to -ptestall or something.