Opened 12 years ago

Closed 12 years ago

#9765 closed defect (fixed)

matrix2.pyx: replace "x < 1e-15" by "abs(x) < 1e-15"

Reported by: John Palmieri Owned by: Alex Ghitza
Priority: blocker Milestone: sage-4.5.3
Component: algebra Keywords:
Cc: Merged in: sage-4.5.3.alpha2
Authors: John Palmieri Reviewers: Mitesh Patel
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

In matrix2.pyx, there is a doctest (line 6406):

            sage: all(imag(e) < 1.1e-15 for e in eigs)

We should replace "imag(e)" by "abs(imag(e))".

The attached patch depends on #9760.

Attachments (1)

trac_9765-matrix2-abs.patch (1.2 KB) - added by John Palmieri 12 years ago.

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by John Palmieri

Attachment: trac_9765-matrix2-abs.patch added

comment:1 Changed 12 years ago by John Palmieri

Status: newneeds_review

comment:2 Changed 12 years ago by Mitesh Patel

Reviewers: Mitesh Patel
Status: needs_reviewpositive_review

The test still passes on bsd, redhawk, sage, and t2.math.

comment:3 Changed 12 years ago by Mitesh Patel

Milestone: sage-4.6sage-4.5.3
Priority: majorblocker

comment:4 Changed 12 years ago by Mitesh Patel

Merged in: sage-4.5.3.alpha2
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.