Opened 10 years ago

Closed 10 years ago

#9765 closed defect (fixed)

matrix2.pyx: replace "x < 1e-15" by "abs(x) < 1e-15"

Reported by: jhpalmieri Owned by: AlexGhitza
Priority: blocker Milestone: sage-4.5.3
Component: algebra Keywords:
Cc: Merged in: sage-4.5.3.alpha2
Authors: John Palmieri Reviewers: Mitesh Patel
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

In matrix2.pyx, there is a doctest (line 6406): 

            sage: all(imag(e) < 1.1e-15 for e in eigs)

We should replace "imag(e)" by "abs(imag(e))".

The attached patch depends on #9760.

Attachments (1)

trac_9765-matrix2-abs.patch​ (1.2 KB) - added by jhpalmieri 10 years ago.

Download all attachments as: .zip

Change History (5)

Changed 10 years ago by jhpalmieri

comment:1 Changed 10 years ago by jhpalmieri

  • Status changed from new to needs_review

comment:2 Changed 10 years ago by mpatel

  • Reviewers set to Mitesh Patel
  • Status changed from needs_review to positive_review

The test still passes on bsd, redhawk, sage, and t2.math.

comment:3 Changed 10 years ago by mpatel

  • Milestone changed from sage-4.6 to sage-4.5.3
  • Priority changed from major to blocker

comment:4 Changed 10 years ago by mpatel

  • Merged in set to sage-4.5.3.alpha2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.