Opened 10 years ago

Closed 10 years ago

#9764 closed enhancement (fixed)

Change hashing and printing for NumberFieldIdeals

Reported by: jdemeyer Owned by: davidloeffler
Priority: major Milestone: sage-4.6
Component: number fields Keywords: number field ideal hash
Cc: was Merged in: sage-4.6.alpha2
Authors: William Stein, Jeroen Demeyer Reviewers: David Loeffler
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

This ticket is a fork from #9400.

  • implement hashing for number field ideals that isn't a stupid string repr, hence vastly faster
  • make number field ideals *not* print in reduced form; this will look uglier, but is massively faster and more sensible for any real applications, as people learned constantly at sage days 22.

Dependencies: #9898, #9753

Apply only 9764_ideal_repr_new.patch

Attachments (2)

9764_ideal_repr.patch (17.5 KB) - added by jdemeyer 10 years ago.
Patch against sage-4.5.3.alpha0
9764_ideal_repr_new.patch (17.4 KB) - added by jdemeyer 10 years ago.
Patch against sage-4.6.alpha0 + #9400 + #9898 + #9753

Download all attachments as: .zip

Change History (10)

comment:1 Changed 10 years ago by jdemeyer

  • Status changed from new to needs_work

Needs to be rebased to #9343.

Changed 10 years ago by jdemeyer

Patch against sage-4.5.3.alpha0

comment:2 Changed 10 years ago by jdemeyer

  • Authors changed from William Stein to William Stein, Jeroen Demeyer

comment:3 Changed 10 years ago by jdemeyer

  • Keywords number field ideal hash added
  • Status changed from needs_work to needs_review

Changed 10 years ago by jdemeyer

Patch against sage-4.6.alpha0 + #9400 + #9898 + #9753

comment:4 Changed 10 years ago by davidloeffler

  • Reviewers set to David Loeffler
  • Status changed from needs_review to positive_review

I applied this to sage-4.6.alpha1 with #9898 and #9753 installed. Changes look sensible, patch applies fine, and all doctests pass. Positive review.

comment:5 Changed 10 years ago by jdemeyer

  • Description modified (diff)

comment:6 Changed 10 years ago by jdemeyer

  • Description modified (diff)

comment:7 Changed 10 years ago by mpatel

  • Merged in set to sage-4.6.alpha2

comment:8 Changed 10 years ago by mpatel

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.