Opened 10 years ago

Closed 10 years ago

#9753 closed enhancement (fixed)

Simplify NumberFieldIdeal.gens_reduced()

Reported by: jdemeyer Owned by: davidloeffler
Priority: major Milestone: sage-4.6
Component: number fields Keywords: number field ideal gens_two idealtwoelt
Cc: Merged in: sage-4.6.alpha2
Authors: Jeroen Demeyer Reviewers: David Loeffler
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

The function NumberFieldIdeal?.gens_reduced() can be simplified quite a bit without essentially changing its functionality. We can also add a new function gens_two() which writes a number field ideal using two generators, like PARI's idealtwoelt().

Dependencies: #9400, #9898

Attachments (2)

9753.patch​ (19.3 KB) - added by jdemeyer 10 years ago.
Adds function gens_two(), rewrites gens_reduced() and fixes doctests
9753-better_commit_string.patch​ (19.3 KB) - added by davidloeffler 10 years ago.
New version with better commit string

Download all attachments as: .zip

Change History (11)

comment:1 Changed 10 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Status changed from new to needs_work

I will wait to fix the doctests until after #9343 and #9400.

comment:2 Changed 10 years ago by jdemeyer

  • Description modified (diff)

comment:3 Changed 10 years ago by jdemeyer

  • Status changed from needs_work to needs_review

Changed 10 years ago by jdemeyer

Adds function gens_two(), rewrites gens_reduced() and fixes doctests

comment:4 Changed 10 years ago by jdemeyer

  • Description modified (diff)

comment:5 Changed 10 years ago by jdemeyer

  • Keywords number field ideal gens_two idealtwoelt added
  • Type changed from defect to enhancement

comment:6 Changed 10 years ago by davidloeffler

  • Reviewers set to David Loeffler
  • Status changed from needs_review to positive_review

Looks fine to me, and all tests pass on my machine.

comment:7 Changed 10 years ago by mpatel

  • Status changed from positive_review to needs_work

Could someone update the patch commit string with a more descriptive first line (still including the ticket number) and restore the positive review?

Changed 10 years ago by davidloeffler

New version with better commit string

comment:8 Changed 10 years ago by davidloeffler

  • Status changed from needs_work to positive_review

Done.

comment:9 Changed 10 years ago by mpatel

  • Merged in set to sage-4.6.alpha2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.