Opened 12 years ago
Closed 12 years ago
#9753 closed enhancement (fixed)
Simplify NumberFieldIdeal.gens_reduced()
Reported by: | jdemeyer | Owned by: | davidloeffler |
---|---|---|---|
Priority: | major | Milestone: | sage-4.6 |
Component: | number fields | Keywords: | number field ideal gens_two idealtwoelt |
Cc: | Merged in: | sage-4.6.alpha2 | |
Authors: | Jeroen Demeyer | Reviewers: | David Loeffler |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
The function NumberFieldIdeal?.gens_reduced() can be simplified quite a bit without essentially changing its functionality. We can also add a new function gens_two()
which writes a number field ideal using two generators, like PARI's idealtwoelt()
.
Attachments (2)
Change History (11)
comment:1 Changed 12 years ago by
- Status changed from new to needs_work
comment:2 Changed 12 years ago by
- Description modified (diff)
comment:3 Changed 12 years ago by
- Status changed from needs_work to needs_review
comment:4 Changed 12 years ago by
- Description modified (diff)
comment:5 Changed 12 years ago by
- Keywords number field ideal gens_two idealtwoelt added
- Type changed from defect to enhancement
comment:6 Changed 12 years ago by
- Reviewers set to David Loeffler
- Status changed from needs_review to positive_review
Looks fine to me, and all tests pass on my machine.
comment:7 Changed 12 years ago by
- Status changed from positive_review to needs_work
Could someone update the patch commit string with a more descriptive first line (still including the ticket number) and restore the positive review?
comment:9 Changed 12 years ago by
- Merged in set to sage-4.6.alpha2
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
I will wait to fix the doctests until after #9343 and #9400.