Changes between Version 69 and Version 75 of Ticket #9739


Ignore:
Timestamp:
09/10/11 20:59:38 (9 years ago)
Author:
jhpalmieri
Comment:

Here are some new patches. First, trac_9739.v2.patch and a "delta" patch trac_9739-delta1to2.patch: the differences from the previous version are

  • It changes how filenames are mangled: it uses "NAME_PID.py" instead of "doctest_PID_NAME.py" or whatever what there before.
  • I've decided that I agree with you: we shouldn't print the messages about removing the doctesting directory every time. I've changed it so it only prints them if "-verbose" is one of the command-line options. (This is overusing the "-verbose" option, I suppose, so we could instead could completely disable printing just by setting the variable "verbose" in sage-ptest to be False always.) If the directory is not deleted at the end, then a message is printed regardless of verbosity settings.

Along these lines, we have trac_9739-graphviz.patch, a patch for the main Sage library, which writes a temporary file to SAGE_TMP rather than to SAGE_TESTDIR, so that the doctesting directory is indeed empty after doctesting the Sage library.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #9739

    • Property Priority changed from critical to blocker
  • Ticket #9739 – Description

    v69 v75  
    3333-------
    3434
    35 Apply only [attachment:trac_9739.patch].
     35Apply
     36
     37 - [attachment:trac_9739.v2.patch] to the scripts repository
     38 - [attachment:trac_9739-graphviz.patch] to the Sage library