Opened 11 years ago

Closed 11 years ago

#9712 closed defect (fixed)

Make building PolyBoRi depend on GD

Reported by: leif Owned by: tbd
Priority: blocker Milestone: sage-4.5.3
Component: packages: standard Keywords:
Cc: leif, malb Merged in: sage-4.5.3.alpha1
Authors: Mitesh Patel Reviewers: Leif Leonhardy
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

From #9472:

"Since PolyBoRi also uses GD, $SAGE_ROOT/spkg/standard/deps should be updated (but there seem to have been no issues with that in the past)."

Attachments (2)

deps (18.0 KB) - added by mpatel 11 years ago.
Updated spkg/standard/deps. Based on 4.5.2 + #8316.
deps.diff (547 bytes) - added by mpatel 11 years ago.
Diff of spkg/standard/deps vs. 4.5.2 + #8316.

Download all attachments as: .zip

Change History (9)

Changed 11 years ago by mpatel

Updated spkg/standard/deps. Based on 4.5.2 + #8316.

Changed 11 years ago by mpatel

Diff of spkg/standard/deps vs. 4.5.2 + #8316.

comment:1 follow-up: Changed 11 years ago by mpatel

  • Status changed from new to needs_review

I've attached a new deps and deps.diff.

I'm not sure whether to put Leif or Martin as the author, or both Leif and Martin. Can someone please update the field?

comment:2 in reply to: ↑ 1 Changed 11 years ago by leif

  • Authors set to Mitesh Patel

Replying to mpatel:

I'm not sure whether to put Leif or Martin as the author, or both Leif and Martin. Can someone please update the field?

Can you update the "Reported by:" field? ;-)

From PolyBoRi's SPKG.txt:

...

== Dependencies ==

 * Python
 * Scons
 * Boost
 * gd (FIXME/TODO: should be added to deps, I think. Leif, 2010-07-10)
 * M4RI/libm4ri (already included in deps)
 * png/libpng12 (accomplished because Python and gd depend on it, too)
 * libz         (accomplished because e.g. libpng depends on it)

...

I must admit I did not check all transitive dependencies, i.e. if some package that PolyBoRi (indirectly) depends on pulls in the GD dependency. Anyway, I think it's always better to add an explicit, perhaps "redundant" dependency rather than to omit it, (not only) since the deps of other packages might change over the time. (Same for explicitly linking against libraries directly used despite other used libraries - currently - already doing so.)

The only package in standard/deps that's listed to directly depend on GD is gdmodule, which in turn is only listed as a (direct) dependency of MatPlotLib (and the Sage library).

comment:3 Changed 11 years ago by leif

  • Reviewers set to Leif Leonhardy
  • Status changed from needs_review to positive_review

I've only "reviewed" deps.diff though... :)

comment:4 Changed 11 years ago by mpatel

  • Reporter changed from mpatel to leif

comment:5 Changed 11 years ago by leif

I'm pretty sure it's just good luck this ever worked. GD is one of the "early" packages, and all of these take little time to build.

I'll perhaps verify that later by forcing GD to be built very late.

comment:6 Changed 11 years ago by leif

P.S.: The suggestion to change the "Reported by:" field was just a joke.

comment:7 Changed 11 years ago by mpatel

  • Merged in set to sage-4.5.3.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.