Changes between Initial Version and Version 28 of Ticket #9706


Ignore:
Timestamp:
10/15/10 23:31:17 (11 years ago)
Author:
maldun
Comment:

@kcrisman thanks for paying attention. I added now an updated patch and extended instructions.

the doctest changes in symbolic.random_tests.py are easy to explain: new functions are involved -> new random expressions. But I had to change random_expr(50, nvars=3, coeff_generator=CDF.random_element) to random_expr(60, nvars=3, coeff_generator=CDF.random_element) or else one gets an expression generated where a division through zero occours.

As mentioned on sage-devel I repaired the doctests in symbolic.pynac.pyx, the trick is to enlarge the range of the for loop: for i in range(get_ginac_serial(), get_ginac_serial()+50): changed to for i in range(get_ginac_serial(), get_ginac_serial()+100): now it works. My explaination: since we have new functions we have longer to search, and then we reach our goal. What I can not explain is, that it works, when I type it in by hand.

All doctests pass now, so I think a review would be nice.

-maldun

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #9706

    • Property Status changed from new to needs_review
    • Property Cc fredrik.johansson added
    • Property Milestone changed from to sage-5.0
    • Property Owner changed from burcin to burcin, maldun
    • Property Type changed from defect to enhancement
  • Ticket #9706 – Description

    initial v28  
    11The current implementation of orthogonal polynomials is just a wrapper around maxima. (see http://wiki.sagemath.org/symbolics/)
    2 There are the following improvements planed:
     2This update holds the following changes:
    33
    4 -using of the pynac class for symbolic functions.
    5 -faster evaluation in general
    6 -evaluation of special values
    7 -mpmath for numeric evaluation
     4  *using of the pynac class for symbolic functions.
     5  *faster evaluation in general
     6  *evaluation of special values
     7  *mpmath for numeric evaluation
    88
    9 
     9'''Remarks:'''
     10   *The current patch needs scipy-0.8. One has to install it before testing (see #9808 for spkg's and installation instructions)
     11   * Some of the old doctests in the old file don't work any more, due to coercion problems with pynac (see #9769)
     12   * Some doctests in Sage change, due to the fact that new BuiltIn functions are added. symbolic.random_test.py had output changes since the random expression creation changed of course. The tests in pynac.pyx also changed, but this has a strange behavior (see below).