Opened 11 years ago

Last modified 11 years ago

#9681 closed defect

Missing dependancy in spkg/standard/deps for zn_poly. — at Version 1

Reported by: drkirkby Owned by: GeorgSWeber
Priority: minor Milestone: sage-duplicate/invalid/wontfix
Component: build Keywords:
Cc: ddrake, mpatel, leif, jhpalmieri Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by drkirkby)

The zn_poly package lists in SPKG.txt the only dependencies are GMP, but this is not true, as zn_poly's configure script has in it:

/configure --gmp-prefix="$SAGE_LOCAL" --ntl-prefix="$SAGE_LOCAL" \
            --prefix="$SAGE_LOCAL" --cflags="$CFLAGS" --ldflags="$LDFLAGS"

So zn_poly depends on ntl

Looking at $SAGE_ROOT/spkg/standard/deps, I see:

$(INST)/$(ZNPOLY): $(BASE) $(INST)/$(MPIR)
        $(INSTALL) "$(SAGE_SPKG) $(ZNPOLY) 2>&1" "tee -a $(SAGE_LOGS)/$(ZNPOLY).log"

i.e. no such dependency is directly listed.

Then looking at MPIR I see the dependencies are only BASE and ICONV. But ICONV only depends on BASE, so there is nothing to force ntl to build before zn_poly, despite zn_poly depends on ntl

I am aware of two other changes that are desirable in the 'deps' file too, as they add clarity.

These might as well be fixed at the same time.

Dave

Change History (3)

comment:1 Changed 11 years ago by drkirkby

  • Description modified (diff)

Changed 11 years ago by drkirkby

Updated deps file, which solves this major problem and corrects two minor ones in #9464 and #9637

Changed 11 years ago by drkirkby

Unifier diff file for $SAGE_ROOT/spkg/standard/deps

Note: See TracTickets for help on using tickets.