Opened 12 years ago

Last modified 12 years ago

#9603 closed defect

Force iconv to build on HP-UX in addition to Solaris and Cygwin. — at Initial Version

Reported by: David Kirkby Owned by: Georg S. Weber
Priority: major Milestone: sage-4.6
Component: build Keywords:
Cc: Peter Jeremy, Minh Van Nguyen, Mitesh Patel Merged in:
Authors: David Kirkby Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Currently iconv builds only on Solaris and Cygwin, as it caused problems on some linux distributions.

It would be good if this would build on HP-UX too, as then some other packages could be checked on HP-UX to aid testing on different platforms. This ticket makes 3 changes.

  • Changes #!/bin/bash to #!/usr/bin/env bash in spkg-check. This in in conformance with the Sage Developers Guide and is necessary on HP-UX as 'bash' is not installed in /bin.
-#!/bin/bash
+#!/usr/bin/env bash
  • Force install on HP-UX, instead of just Cygwin and Solaris. The relevant bit of the patch is:
    -# Only build iconv on Solaris and Cygwin
    -if [ "x$UNAME" != xSunOS ] && [ "x$UNAME" != xCYGWIN ] ; then  
    +# Only build iconv on Solaris, HP-UX and Cygwin
    +if [ "x$UNAME" != xSunOS ] && [ "x$UNAME" != xHP-UX ] && [ "x$UNAME" != xCYGWIN ] ; then
    
  • Force iconv to be checked only HP-UX, in addition to Solaris and Cygwin on which it was previously checked.
    -if [ "x$UNAME" != xSunOS ] && [ "x$UNAME" != xCYGWIN ] ; then  
    +if [ "x$UNAME" != xSunOS ] && [ "x$UNAME" != xHP-UX ] && [ "x$UNAME" != xCYGWIN ] ; then
    
  • Print all tests have pass if they have done. The relevant bit of the patch is
+echo "All the tests for iconv passed"
+exit 0 

Change History (0)

Note: See TracTickets for help on using tickets.