Changes between Initial Version and Version 33 of Ticket #9603
- Timestamp:
- 08/26/10 22:25:10 (12 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #9603
-
Property
Status
changed from
new
toneeds_info
- Property Cc pjeremy mvngu mpatel added
-
Property
Summary
changed from
Force iconv to build on HP-UX in addition to Solaris and Cygwin.
toSpeed up installation of iconv by permitting parallel builds. Also install iconv on HP-UX
-
Property
Milestone
changed from
sage-5.0
tosage-4.5.3
- Property Owner changed from GeorgSWeber to drkirkby
-
Property
Reviewers
changed from
to
Peter Jeremy, Leif Leonhardy
-
Property
Status
changed from
-
Ticket #9603 – Description
initial v33 1 1 Currently iconv builds only on Solaris and Cygwin, as it caused problems on some linux distributions. 2 2 3 It would be good if this would build on HP-UX too, as then some other packages could be checked on HP-UX to aid testing on different platforms. This ticket makes 3 changes.3 Currently, iconv is built serially, using {{{make}}} rather than {{{$MAKE}}}. This needs changing to permit faster builds. 4 4 5 * Changes {{{#!/bin/bash}}} to {{{#!/usr/bin/env bash}}} in spkg-check. This in in conformance with the [http://www.sagemath.org/doc/developer/producing_spkgs.html#creating-a-new-spkg Sage Developers Guide] and is necessary on HP-UX as 'bash' is not installed in /bin. 5 It would be good if iconv would build on HP-UX too, as then some other packages could be checked on HP-UX to aid testing on different platforms. 6 6 7 {{{ 8 -#!/bin/bash 9 +#!/usr/bin/env bash 10 }}} 11 12 * Force install on HP-UX, instead of just Cygwin and Solaris. The relevant bit of the patch is: 13 {{{ 14 -# Only build iconv on Solaris and Cygwin 15 -if [ "x$UNAME" != xSunOS ] && [ "x$UNAME" != xCYGWIN ] ; then 16 +# Only build iconv on Solaris, HP-UX and Cygwin 17 +if [ "x$UNAME" != xSunOS ] && [ "x$UNAME" != xHP-UX ] && [ "x$UNAME" != xCYGWIN ] ; then 18 }}} 19 * Force iconv to be checked only HP-UX, in addition to Solaris and Cygwin on which it was previously checked. 20 {{{ 21 -if [ "x$UNAME" != xSunOS ] && [ "x$UNAME" != xCYGWIN ] ; then 22 +if [ "x$UNAME" != xSunOS ] && [ "x$UNAME" != xHP-UX ] && [ "x$UNAME" != xCYGWIN ] ; then 23 }}} 24 25 * Print all tests have pass if they have done. The relevant bit of the patch is 26 27 {{{ 28 +echo "All the tests for iconv passed" 29 +exit 0 30 }}} 7 A cleanup of spkg-install, spkg-check and SPKG.txt was also undertaken.