Opened 10 years ago

Closed 10 years ago

#9580 closed defect (fixed)

Check in, ignore, or delete sagenb.po in SageNB package

Reported by: mpatel Owned by: jason, was
Priority: minor Milestone: sage-4.5.2
Component: notebook Keywords:
Cc: timdumol Merged in: sagenb-0.8.2
Authors: Tim Dumol Reviewers: Mitesh Patel
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Noted by Leif Leonhardy in a comment at #9554:

leif@portland:~/Sage/spkgs/sagenb-0.8.1.p1/src/sagenb$ hg status
? sagenb/sagenb.po

Change History (10)

comment:1 Changed 10 years ago by leif

<timdumol> _leif: Thanks for spotting the rogue .po file (I forgot to remove it from #9428 when I build 0.8.1)

(About 14 hours ago.)

Nevertheless, I'll add it to #9572 (SageNB 0.8.2).

comment:2 Changed 10 years ago by leif

find . -name .hg -exec sh -c "cd {}; hg status" \;

;-)

comment:3 follow-up: Changed 10 years ago by mpatel

Just to check: Should I just delete sagenb/sagenb.po?

comment:4 in reply to: ↑ 3 Changed 10 years ago by leif

Replying to mpatel:

Just to check: Should I just delete sagenb/sagenb.po?

According to what Tim said, I think yes.

comment:5 Changed 10 years ago by mpatel

  • Cc timdumol added

comment:6 Changed 10 years ago by mpatel

  • Summary changed from Check in or ignore sagenb.po in SageNB package to Check in, ignore, or delete sagenb.po in SageNB package

comment:7 Changed 10 years ago by mpatel

  • Authors set to Tim Dumol
  • Milestone set to sage-4.5.2
  • Status changed from new to needs_review

If no one objects, I'll list Tim as this ticket's author.

comment:8 Changed 10 years ago by mpatel

  • Reviewers set to Mitesh Patel
  • Status changed from needs_review to positive_review

It should be safe to delete sagenb/sagenb.po, particularly since #9428 has not merged.

comment:9 Changed 10 years ago by mpatel

  • Merged in set to sagenb-0.8.2

I've merged this ticket into the latest SageNB 0.8.2 at #9572.

comment:10 Changed 10 years ago by mpatel

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.