Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#9570 closed defect (fixed)

Wrong LP solver ordering

Reported by: ncohen Owned by: jason, jkantor
Priority: major Milestone: sage-4.5.2
Component: numerical Keywords:
Cc: Merged in: sage-4.5.2.alpha1
Authors: Nathann Cohen, Leonardo Sampaio Reviewers: Nathann Cohen, Leonardo Sampaio
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

At the moment, GLPK is the solver used regardless of the presence of CBC or CPLEX. This is just because of a line written ten lines too high in the file !

Nathann

Attachments (2)

trac_9570.patch (1.1 KB) - added by ncohen 9 years ago.
trac_9570-fix.patch (939 bytes) - added by lsampaio 9 years ago.
Fixes the AttributeError? that was returned when no mip solver was specified by the user

Download all attachments as: .zip

Change History (7)

Changed 9 years ago by ncohen

comment:1 Changed 9 years ago by ncohen

  • Status changed from new to needs_review

Changed 9 years ago by lsampaio

Fixes the AttributeError? that was returned when no mip solver was specified by the user

comment:2 Changed 9 years ago by lsampaio

I applied your patch, but while trying to solve an MIP without specifying a solver, I've got an AttributeError?, since the attribute '_default_solver' was not defined. I just fixed this by adding a line stating that _default_solver = None. If you agree with my changes, I think the patch can be said to be reviwed.

comment:3 Changed 9 years ago by ncohen

  • Authors set to Nathann Cohen, Leonardo Sampaio
  • Reviewers set to Nathann Cohen, Leonardo Sampaio
  • Status changed from needs_review to positive_review

Excellent ! Thank you very much for your help :-)

Both apply fine and in the end, it works... Now the annoying part is #8880 because CPLEX is called by next-to-any method in the LP library XD

Nathann

comment:4 Changed 9 years ago by ddrake

  • Merged in set to sage-4.5.2.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed

Leonardo -- be sure to use informative commit messages for your patches. "fix" is not very helpful. :) Always include a ticket number, too. I changed your commit message to "ticket 9570: insure _default_solver attribute exists".

both patches merged in 4.5.2.alpha1.

comment:5 Changed 9 years ago by lsampaio

ok, thanks for the advice =)

Note: See TracTickets for help on using tickets.