Opened 11 years ago
Closed 11 years ago
#9566 closed enhancement (fixed)
Allow sage.libs.mpmath.call(..., parent=something)
Reported by: | fredrik.johansson | Owned by: | AlexGhitza |
---|---|---|---|
Priority: | major | Milestone: | sage-4.5.2 |
Component: | algebra | Keywords: | |
Cc: | burcin | Merged in: | sage-4.5.2.alpha1 |
Authors: | Fredrik Johansson | Reviewers: | Harald Schilly |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
This can simplify code that needs to call mpmath in some places.
Attachments (3)
Change History (10)
Changed 11 years ago by
Changed 11 years ago by
comment:1 Changed 11 years ago by
- Milestone set to sage-4.5.2
- Status changed from new to needs_review
- Type changed from defect to enhancement
works for me
comment:2 Changed 11 years ago by
- Status changed from needs_review to positive_review
comment:3 Changed 11 years ago by
- Reviewers set to Harald Schilly
- Status changed from positive_review to needs_work
Please include ticket numbers in commit messages! Please change back to positive review when both patches are fixed up. Thanks.
comment:4 Changed 11 years ago by
Added mpmath_call_FIXED.patch
I fixed an error in the first patch (there shouldn't be a new kwarg in mpmath_to_sage) and included Harald's change with an extra line to also print the type of the output.
comment:5 Changed 11 years ago by
- Status changed from needs_work to needs_review
- Summary changed from [with patch, needs review] Allow sage.libs.mpmath.call(..., parent=something) to Allow sage.libs.mpmath.call(..., parent=something)
comment:6 follow-up: ↓ 7 Changed 11 years ago by
- Status changed from needs_review to positive_review
dear release manager, just merge mpmath_call_FIXED.patch and ignore the others.
comment:7 in reply to: ↑ 6 Changed 11 years ago by
- Merged in set to sage-4.5.2.alpha1
- Resolution set to fixed
- Status changed from positive_review to closed
Replying to schilly:
dear release manager, just merge mpmath_call_FIXED.patch and ignore the others.
Done. Thanks for fixing the commit messages!
does it make sense to also test for parent RDF ?