Opened 11 years ago

Closed 11 years ago

#9566 closed enhancement (fixed)

Allow sage.libs.mpmath.call(..., parent=something)

Reported by: fredrik.johansson Owned by: AlexGhitza
Priority: major Milestone: sage-4.5.2
Component: algebra Keywords:
Cc: burcin Merged in: sage-4.5.2.alpha1
Authors: Fredrik Johansson Reviewers: Harald Schilly
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

This can simplify code that needs to call mpmath in some places.

Attachments (3)

mpmath_call.patch​ (5.0 KB) - added by fredrik.johansson 11 years ago.
mpmath_call_reviewer.patch​ (790 bytes) - added by schilly 11 years ago.
does it make sense to also test for parent RDF ?
mpmath_call_FIXED.patch​ (4.9 KB) - added by fredrik.johansson 11 years ago.
fixed patch

Download all attachments as: .zip

Change History (10)

Changed 11 years ago by fredrik.johansson

Changed 11 years ago by schilly

does it make sense to also test for parent RDF ?

comment:1 Changed 11 years ago by schilly

  • Milestone set to sage-4.5.2
  • Status changed from new to needs_review
  • Type changed from defect to enhancement

works for me

comment:2 Changed 11 years ago by schilly

  • Status changed from needs_review to positive_review

comment:3 Changed 11 years ago by ddrake

  • Authors set to Fredrik Johansson
  • Reviewers set to Harald Schilly
  • Status changed from positive_review to needs_work

Please include ticket numbers in commit messages! Please change back to positive review when both patches are fixed up. Thanks.

Changed 11 years ago by fredrik.johansson

fixed patch

comment:4 Changed 11 years ago by fredrik.johansson

Added mpmath_call_FIXED.patch

I fixed an error in the first patch (there shouldn't be a new kwarg in mpmath_to_sage) and included Harald's change with an extra line to also print the type of the output.

comment:5 Changed 11 years ago by fredrik.johansson

  • Status changed from needs_work to needs_review
  • Summary changed from [with patch, needs review] Allow sage.libs.mpmath.call(..., parent=something) to Allow sage.libs.mpmath.call(..., parent=something)

comment:6 follow-up: Changed 11 years ago by schilly

  • Status changed from needs_review to positive_review

dear release manager, just merge mpmath_call_FIXED.patch and ignore the others.

comment:7 in reply to: ↑ 6 Changed 11 years ago by ddrake

  • Merged in set to sage-4.5.2.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed

Replying to schilly:

dear release manager, just merge mpmath_call_FIXED.patch and ignore the others.

Done. Thanks for fixing the commit messages!

Note: See TracTickets for help on using tickets.