Opened 11 years ago

Closed 8 years ago

#9559 closed enhancement (fixed)

*generalized* canonical generation in Cython

Reported by: rlm Owned by: rlm
Priority: major Milestone: sage-5.7
Component: group theory Keywords:
Cc: boothby, ncohen, kini, dimpase Merged in: sage-5.7.beta0
Authors: Robert Miller Reviewers: Tom Boothby
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by rlm)

The basic idea is that one has objects which satisfy the criteria set out in sage/groups/perm_gps/partn_ref. In particular, one has implemented a refinement function, a comparison function, and an equivalent-children function. Then one defines the following four functions, and the code which will appear here will do the rest.

  1. Given an input object X, this function will return a number k. This is the number of augmentations from X to perform, thought of abstractly as the list [0, 1, ..., k-1]. The user will keep the data of what augmentations these actually are.
  1. Given a permutation of X (acting on [0, 1, ..., n-1]), and a number a in [0, 1, ..., k-1], outputs a number b in the same range, such that the augmentation represented by a maps to the one represented by b under the permutation.
  1. Given a number in [0, 1, ..., k-1], outputs an object C which realizes the augmentation.
  1. Given a permutation g, and an object C, applies g to C, constructs an arbitrary parent object P of C, and returns g^(-1)(P).

Function (2) will be optional. If not provided, then the list of augmentations given in (1) will have to be a set of orbit representatives.

NOTE: ticket #11369 should be set to needs_review once this one is ready

Attachments (1)

trac_9559.patch (185.8 KB) - added by rlm 8 years ago.

Download all attachments as: .zip

Change History (18)

comment:1 Changed 11 years ago by rlm

  • Owner changed from joyner to rlm

comment:2 Changed 10 years ago by rlm

  • Description modified (diff)

comment:3 Changed 10 years ago by rlm

  • Description modified (diff)

comment:4 Changed 10 years ago by rlm

  • Dependencies set to #10549, #10804
  • Milestone changed from sage-5.0 to sage-4.7.1

comment:5 Changed 10 years ago by rlm

  • Status changed from new to needs_review

comment:6 Changed 10 years ago by ncohen

  • Cc ncohen added

comment:7 Changed 9 years ago by boothby

  • Status changed from needs_review to positive_review

comment:8 Changed 9 years ago by rlm

  • Reviewers set to Tom Boothby

comment:9 Changed 9 years ago by boothby

477c477,478
< groups/perm_gps/partn_ref/refinement_graphs.pyx: 100% (8 of 8)
---
> groups/perm_gps/partn_ref/refinement_graphs.pyx: 100% (10 of 10)
> groups/perm_gps/partn_ref/refinement_sets.pyx: 100% (3 of 3)
1299,1300c1300,1301
< Total number of functions:  28567
< We need 1110 more function to get to 90% coverage.
---
> Total number of functions:  28572
> We need 1109 more function to get to 90% coverage.

comment:10 Changed 9 years ago by jdemeyer

  • Status changed from positive_review to needs_work
  • Work issues set to formatting

The commit message needs to be fixed, it certainly should not contain "[mq]".

Newly added files should conform to the template at http://sagemath.org/doc/developer/conventions.html#headings-of-sage-library-code-files.

New documentation strings should conform to http://sagemath.org/doc/developer/conventions.html#documentation-strings.

comment:11 Changed 9 years ago by ncohen

  • Description modified (diff)

comment:12 Changed 9 years ago by dimpase

  • Cc kini dimpase added

comment:13 Changed 8 years ago by rlm

  • Dependencies #10549, #10804 deleted
  • Description modified (diff)

Changed 8 years ago by rlm

comment:14 Changed 8 years ago by rlm

  • Status changed from needs_work to needs_review

comment:15 Changed 8 years ago by boothby

  • Status changed from needs_review to positive_review

Tests pass, formatting updated as requested by jdemeyer.

comment:16 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.6 to sage-5.7
  • Work issues formatting deleted

comment:17 Changed 8 years ago by jdemeyer

  • Merged in set to sage-5.7.beta0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.