Opened 9 years ago

Closed 4 years ago

#9552 closed defect (fixed)

cython.py references the old sage notebook code

Reported by: was Owned by: jason
Priority: minor Milestone: sage-6.8
Component: misc Keywords:
Cc: fbissey Merged in:
Authors: Jeroen Demeyer Reviewers: François Bissey
Report Upstream: N/A Work issues:
Branch: 1fc034e (Commits) Commit: 1fc034eda517210fee9afa56b60dfe4ff39f6586
Dependencies: Stopgaps:

Description (last modified by kcrisman)

I noticed to my surprise that misc/cython.py has these lines in it (which should be fixed, of course):

 import sage.server.support
    d = {}
    sage.server.support.cython_import_all(tmpfile, d,
                                         verbose=verbose, compile_message=compile_message,
                                         use_cache=use_cache,
                                         create_local_c_file=False)

Change History (12)

comment:1 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:2 Changed 6 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:3 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:4 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:5 Changed 5 years ago by kcrisman

  • Description modified (diff)
  • Summary changed from cython.pyx references the old sage notebook code to cython.py references the old sage notebook code

Yeah, I think a lot of that stuff could go elsewhere, it's just support...

In this case the "right" fix is to move the whole Cython stuff somewhere else, probably just to cython.py (which is not a pyx file, at least not any more).

comment:6 Changed 5 years ago by kcrisman

Indeed, this wouldn't be hard to do. Worst-case we could move them but leave a deprecation that points to the new location (cython.py seems best).

sage: search_src('cython_import')
misc/cython.py:657:    sage.server.support.cython_import_all(tmpfile, d,
misc/cython.py:756:    from sage.server.support import cython_import
misc/cython.py:757:    return cython_import(file, create_local_c_file=False)
misc/cython_c.pyx:61:    sage.server.support.cython_import_all(tmpfile, globals(),
server/support.py:425:def cython_import(filename, verbose=False, compile_message=False,
server/support.py:452:def cython_import_all(filename, globals, verbose=False, compile_message=False,
server/support.py:468:    m = cython_import(filename, verbose=verbose, compile_message=compile_message,

The notebook already has its own versions of these two functions so that is not a problem, as far as I can tell (though it wouldn't hurt testing it can still Cythonize after doing this).

comment:7 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/9552

comment:8 Changed 5 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Commit set to 325ca9ca11b9ade262297562989a8ca1ff398eab
  • Milestone changed from sage-6.4 to sage-6.6
  • Status changed from new to needs_review

New commits:

325ca9cMove Cython functions from server/support.py to misc/cython.py

comment:9 Changed 4 years ago by git

  • Commit changed from 325ca9ca11b9ade262297562989a8ca1ff398eab to 1fc034eda517210fee9afa56b60dfe4ff39f6586

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

1fc034eMove Cython functions from server/support.py to misc/cython.py

comment:10 Changed 4 years ago by jdemeyer

  • Cc fbissey added
  • Milestone changed from sage-6.6 to sage-6.8

comment:11 Changed 4 years ago by fbissey

  • Reviewers set to François Bissey
  • Status changed from needs_review to positive_review

Looks good to me.

comment:12 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/9552 to 1fc034eda517210fee9afa56b60dfe4ff39f6586
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.