Opened 9 years ago

Closed 8 years ago

#9534 closed enhancement (fixed)

add base method for permutation groups

Reported by: jasonbhill Owned by: jasonbhill
Priority: major Milestone: sage-4.7.2
Component: group theory Keywords: base
Cc: Merged in: sage-4.7.2.alpha4
Authors: Jason Hill Reviewers: Mike Hansen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #10334, #10335 Stopgaps:

Description (last modified by leif)

Patch to add a (working) base method for permutation groups.


Apply trac_9534-permgroup_base.patch to the Sage library.

Attachments (1)

trac_9534-permgroup_base.patch (2.1 KB) - added by mhansen 8 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 9 years ago by jasonbhill

The existing base method returned "Integer Ring" for all permutation groups as it was inherited from ParentWithBase?. This new base method uses GAP's base from stabilizer chain method to return an actual base, with an optional seed.

The patch was placed in the combinat queue as it depends on Mike Hansen's domain modifications.

comment:2 Changed 9 years ago by mhansen

  • Authors changed from jasonbhill to Jason Hill
  • Description modified (diff)
  • Reviewers set to Mike Hansen
  • Status changed from new to needs_review

This is actually Jason's code, and it looks good to me.

comment:3 Changed 9 years ago by mhansen

  • Status changed from needs_review to positive_review

Changed 8 years ago by mhansen

comment:4 Changed 8 years ago by jdemeyer

  • Dependencies set to #10334, #10335
  • Description modified (diff)

comment:5 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.0 to sage-4.7.1

comment:6 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-4.7.1 to sage-4.7.2

comment:7 Changed 8 years ago by jdemeyer

  • Merged in set to sage-4.7.2.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:8 Changed 8 years ago by jdemeyer

  • Merged in sage-4.7.2.alpha0 deleted
  • Resolution fixed deleted
  • Status changed from closed to new

Unmerged because of an issue with #10335.

comment:9 Changed 8 years ago by jdemeyer

  • Status changed from new to needs_review

comment:10 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-4.7.2 to sage-pending
  • Status changed from needs_review to positive_review

comment:11 Changed 8 years ago by leif

  • Description modified (diff)

Does this now have to be rebased on (the rebased) #10335?

In case it does, one should set it to "needs work", otherwise the milestone should be changed to Sage 4.7.2 again.

comment:12 Changed 8 years ago by jdemeyer

  • Merged in set to sage-4.7.2.alpha4
  • Milestone changed from sage-pending to sage-4.7.2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.