Opened 9 years ago

Closed 9 years ago

#9532 closed defect (fixed)

fix uncontrolled randomness in sage/graphs

Reported by: cwitty Owned by: cwitty
Priority: major Milestone: sage-4.5.2
Component: graph theory Keywords:
Cc: rlm Merged in: sage-4.5.2.alpha0
Authors: Carl Witty Reviewers: Robert Miller
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

There are several places in sage/graphs that use random numbers that aren't under the control of randstate.pyx. I'm going to fix them now.

Attachments (1)

trac_9532-graphs-randstate.patch (12.3 KB) - added by cwitty 9 years ago.

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by cwitty

comment:1 Changed 9 years ago by cwitty

  • Cc rlm added
  • Status changed from new to needs_review

OK, the patch is up. I fixed all the randomness I found (except for two calls in two versions of random_stress, which I left alone except for a comment).

comment:2 Changed 9 years ago by rlm

  • Authors set to Carl Witty
  • Reviewers set to Robert Miller
  • Status changed from needs_review to positive_review

Looks good to me.

comment:3 Changed 9 years ago by mpatel

  • Merged in set to sage-4.5.2.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.