Opened 9 years ago

Closed 9 years ago

#9531 closed defect (duplicate)

spkg-check for gsl does not cause an exit on errors.

Reported by: drkirkby Owned by: drkirkby
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: spkg-check Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

The spkg-check file for GNU Scientific Library (GSL) consists of:

#!/usr/bin/env bash

cd src

make check

if [ $? -ne 0 ]; then
   echo "Error: make check for GSL failed"
fi

so the Sage build does not exit if make check fails. This is in contrast to virtually all other spkg-check files, where they would have:

make check

if [ $? -ne 0 ]; then
   echo "Error: make check for GSL failed"
   exit 1
fi

The version of GSL in Sage happens to be almost 3 years old too.

Dave

Change History (2)

comment:1 Changed 9 years ago by drkirkby

I've created #9533 to update the version of GSL and to fix the spkg-check issues at the same time. When #9533 is merged, this ticket can be closed.

comment:2 Changed 9 years ago by mpatel

  • Milestone changed from sage-4.5.3 to sage-duplicate/invalid/wontfix
  • Resolution set to duplicate
  • Status changed from new to closed

I'm closing this as a "duplicate" of #9533.

Note: See TracTickets for help on using tickets.