Opened 11 years ago

Closed 11 years ago

#9527 closed enhancement (fixed)

improve "sage -sh" prompt so it doesn't confuse everybody

Reported by: was Owned by: jason
Priority: minor Milestone: sage-4.5.2
Component: misc Keywords:
Cc: malb Merged in: sage-4.5.2.alpha1
Authors: William Stein Reviewers: Martin Albrecht
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

When doing sage -sh, the result is very, very confusing, since it has the SAGE_ROOT path displayed unlabeled, which causes confusion, and does not show the current path, which also causes confusion. This patch adds a label and the current path, to help reduce confusion some.

Attachments (1)

trac_9527.patch (659 bytes) - added by was 11 years ago.
fix SAGE_ROOT (a separate bug, I guess)

Download all attachments as: .zip

Change History (5)

comment:1 Changed 11 years ago by was

  • Cc malb added
  • Status changed from new to needs_review

Changed 11 years ago by was

fix SAGE_ROOT (a separate bug, I guess)

comment:2 follow-up: Changed 11 years ago by malb

  • Authors set to William Stein
  • Reviewers set to Martin Albrecht
  • Status changed from needs_review to positive_review

The patch looks fine. I'd have preferred to have my PS1 to be embedded in the new PS1, i.e. something like this:

this_is_my_prompt$ sage -sh
SAGE_ROOT=/usr/local/sage-4.3
(sage subshell) this_is_my_prompt$


But it seems this just doesn't work (I tried). This new one is definitely an improvement thus I'll give it a positive review.

comment:3 in reply to: ↑ 2 Changed 11 years ago by was

Replying to malb:

The patch looks fine. I'd have preferred to have my PS1 to be embedded in the new PS1, i.e. something like this:

this_is_my_prompt$ sage -sh
SAGE_ROOT=/usr/local/sage-4.3
(sage subshell) this_is_my_prompt$


But it seems this just doesn't work (I tried).

I tried too, but couldn't figure it out. This patch is meant to be a big improvement, that's all.

comment:4 Changed 11 years ago by ddrake

  • Merged in set to sage-4.5.2.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.