Opened 11 years ago
Closed 10 years ago
#9522 closed defect (fixed)
MPIR: Don't check SAGE_CHECK in spkg-install
Reported by: | mpatel | Owned by: | tbd |
---|---|---|---|
Priority: | minor | Milestone: | sage-duplicate/invalid/wontfix |
Component: | packages: standard | Keywords: | |
Cc: | Merged in: | ||
Authors: | Reviewers: | Leif Leonhardy | |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #8664 | Stopgaps: |
Description
From the end of MPIR's spkg-install
:
if [ "$SAGE_CHECK" = "yes" ]; then cd ..; ./spkg-check fi
We should remove this, since SAGE_LOCAL/bin/sage-spkg
already does this check:
cd $BASEDIR if [ "$SAGE_CHECK" != "" -a -f spkg-check ]; then echo "Running the test suite." chmod +x spkg-check ./spkg-check if [ $? -ne 0 ]; then
Change History (4)
comment:1 follow-up: ↓ 2 Changed 11 years ago by
comment:2 in reply to: ↑ 1 Changed 11 years ago by
comment:3 Changed 11 years ago by
I think there's a good argument for running the mpir test suite every time (i.e. from spkg-install), as it has historically caught several compiler bugs.
It's obviously pointless running it twice.
Dave
comment:4 Changed 10 years ago by
- Dependencies set to #8664
- Milestone changed from sage-4.7.2 to sage-duplicate/invalid/wontfix
- Resolution set to fixed
- Reviewers set to Leif Leonhardy
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
There's already a ticket for updating MPIR to version 2.1.1 (currently needing review), which apparently is aware of this ticket.
I though haven't checked if Mike deleted the superfluous test suite invocation in
spkg-install
.