Opened 12 years ago
Closed 21 months ago
#9512 closed enhancement (invalid)
Sage Source Editor
Reported by: | acleone | Owned by: | jason, was |
---|---|---|---|
Priority: | minor | Milestone: | sage-duplicate/invalid/wontfix |
Component: | notebook | Keywords: | |
Cc: | boothby, acleone, cwitty, chapoton | Merged in: | |
Authors: | Tom Boothby | Reviewers: | Alex Leone |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
Add an "Edit this page" link at the bottom of source files (/src/...) where one can edit the file.
Only user_type(username) == 'admin'
can edit the files.
Attachments (1)
Change History (15)
Changed 12 years ago by
comment:1 Changed 12 years ago by
- Status changed from new to needs_review
comment:2 Changed 12 years ago by
- Reviewers set to Alex Leone
- Status changed from needs_review to positive_review
comment:3 Changed 12 years ago by
comment:4 Changed 12 years ago by
- Merged in set to sagenb-0.8.2
- Resolution set to fixed
- Status changed from positive_review to closed
comment:5 Changed 12 years ago by
- Merged in sagenb-0.8.2 deleted
- Resolution fixed deleted
- Status changed from closed to new
Actually, I found a bug: the "source editor" feature (#9512) converts line endings from Unix to DOS (so once you've edited the file, mercurial thinks every line has changed).
Given the total non-discoverability of #9512, I'm not sure this bug is worth holding up the new spkg; I'll let somebody else decide that.
I also see this behavior. I'm reopening this ticket, changing its status to "needs work," and removing it, for now, from #9572's SageNB 0.8.2.
comment:6 Changed 12 years ago by
- Status changed from new to needs_work
comment:7 Changed 12 years ago by
- Priority changed from trivial to minor
comment:8 Changed 12 years ago by
- Cc cwitty added
comment:9 Changed 9 years ago by
- Milestone changed from sage-5.11 to sage-5.12
comment:10 Changed 8 years ago by
- Milestone changed from sage-6.1 to sage-6.2
comment:11 Changed 8 years ago by
- Milestone changed from sage-6.2 to sage-6.3
comment:12 Changed 8 years ago by
- Milestone changed from sage-6.3 to sage-6.4
comment:13 Changed 22 months ago by
- Cc chapoton added
- Milestone changed from sage-6.4 to sage-duplicate/invalid/wontfix
- Status changed from needs_work to needs_review
Proposing to close all sagenb tickets as outdated, so that all remaining open tickets in the notebook component are about the Jupyter notebook.
comment:14 Changed 21 months ago by
- Resolution set to invalid
- Status changed from needs_review to closed
I'm added the commit string
for the patch I'm merging into SageNB 0.8.2 (#9572).