Opened 12 years ago

Closed 2 years ago

#9512 closed enhancement (invalid)

Sage Source Editor

Reported by: Alex Leone Owned by: jason, was
Priority: minor Milestone: sage-duplicate/invalid/wontfix
Component: notebook Keywords:
Cc: Kelly Boothby, Alex Leone, Carl Witty, Frédéric Chapoton Merged in:
Authors: Tom Boothby Reviewers: Alex Leone
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Add an "Edit this page" link at the bottom of source files (/src/...) where one can edit the file.

Only user_type(username) == 'admin' can edit the files.

Attachments (1)

9512_source_editor.patch (3.9 KB) - added by Kelly Boothby 12 years ago.

Download all attachments as: .zip

Change History (15)

Changed 12 years ago by Kelly Boothby

Attachment: 9512_source_editor.patch added

comment:1 Changed 12 years ago by Kelly Boothby

Status: newneeds_review

comment:2 Changed 12 years ago by Alex Leone

Reviewers: Alex Leone
Status: needs_reviewpositive_review

comment:3 Changed 12 years ago by Mitesh Patel

I'm added the commit string

#9512: Sage source editor.  Tom Boothby

for the patch I'm merging into SageNB 0.8.2 (#9572).

comment:4 Changed 12 years ago by Mitesh Patel

Merged in: sagenb-0.8.2
Resolution: fixed
Status: positive_reviewclosed

comment:5 Changed 12 years ago by Mitesh Patel

Merged in: sagenb-0.8.2
Resolution: fixed
Status: closednew

C. Witty's comment at #9572:

Actually, I found a bug: the "source editor" feature (#9512) converts line endings from Unix to DOS (so once you've edited the file, mercurial thinks every line has changed).

Given the total non-discoverability of #9512, I'm not sure this bug is worth holding up the new spkg; I'll let somebody else decide that.

I also see this behavior. I'm reopening this ticket, changing its status to "needs work," and removing it, for now, from #9572's SageNB 0.8.2.

comment:6 Changed 12 years ago by Mitesh Patel

Status: newneeds_work

comment:7 Changed 12 years ago by Mitesh Patel

Priority: trivialminor

comment:8 Changed 12 years ago by Mitesh Patel

Cc: Carl Witty added

comment:9 Changed 9 years ago by Jeroen Demeyer

Milestone: sage-5.11sage-5.12

comment:10 Changed 9 years ago by For batch modifications

Milestone: sage-6.1sage-6.2

comment:11 Changed 9 years ago by For batch modifications

Milestone: sage-6.2sage-6.3

comment:12 Changed 8 years ago by For batch modifications

Milestone: sage-6.3sage-6.4

comment:13 Changed 2 years ago by Matthias Köppe

Cc: Frédéric Chapoton added
Milestone: sage-6.4sage-duplicate/invalid/wontfix
Status: needs_workneeds_review

Proposing to close all sagenb tickets as outdated, so that all remaining open tickets in the notebook component are about the Jupyter notebook.

comment:14 Changed 2 years ago by Frédéric Chapoton

Resolution: invalid
Status: needs_reviewclosed
Note: See TracTickets for help on using tickets.