Changes between Version 16 and Version 34 of Ticket #9511


Ignore:
Timestamp:
06/24/12 15:07:09 (10 years ago)
Author:
malb
Comment:

I rebased the patch to 5.1.beta5. In particular, this patch removes the line from matrix2.pyx that producses the offending output

sage -t  "devel/sage-main/sage/matrix/matrix2.pyx"          
**********************************************************************
File "/home/vbraun/opt/sage-5.1.beta5/devel/sage-main/sage/matrix/matrix2.pyx", line 9813:
    sage: L
Expected:
    [            3             0             0]
    [    4*a^2 + 1             1             0]
    [      3*a + 2 a^2 + 2*a + 3             3]
Got:
    [            2             0             0]
    [      a^2 + 4             1             0]
    [      2*a + 3 a^2 + 2*a + 3             2]
**********************************************************************

The Cholesky decomposition is not unique over finite fields and we shouldn't test for the output (which can be random depending on which square-root is chosen) but test for L*LT == A. This is done by the line after the line removed in this patch. Hence, correctness is checked. Note that I discussed this off-list Rob Beezer who is the author of the line removed in this patch.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #9511

    • Property Status changed from needs_work to needs_review
    • Property Dependencies changed from #11718 to #12883, #12761
    • Property Cc zimmerma added
    • Property Report Upstream changed from N/A to Reported upstream. No feedback yet.
    • Property Summary changed from Upgrade Givaro to 3.3.x series to Upgrade Givaro to version 3.7.0
  • Ticket #9511 – Description

    v16 v34  
    22
    33 * '''Install''' http://sage.math.washington.edu/home/malb/spkgs/givaro-3.7.0.spkg
    4  * '''Apply''' [attachment:trac_9511_givaro_3_6_x.patch]
     4 * '''Apply''' [attachment:trac_9511_givaro_3_7_x.patch]
    55
    66See https://bitbucket.org/malb/givaro-spkg for SPKG Repository.