Opened 9 years ago

Closed 5 years ago

#9494 closed defect (fixed)

marked mpoly_all() as not tested

Reported by: demosd235 Owned by: mvngu
Priority: major Milestone: sage-6.2
Component: documentation Keywords: sd32
Cc: Merged in:
Authors: Robert Miller Reviewers: Rob Beezer, Benjamin Jones, Ralf Stephan
Report Upstream: N/A Work issues:
Branch: 6f109fa (Commits) Commit: 6f109fad8d6bf24f2622c3f11ca4104445dbe57a
Dependencies: Stopgaps:

Description (last modified by benjaminfjones)

Demo at SD23.5, also increases coverage!


Apply trac_9494-doctest_mpoly_all.2.patch to the Sage library.

Attachments (1)

trac_9494-doctest_mpoly_all.2.patch (964 bytes) - added by benjaminfjones 7 years ago.
marked mpoly_all() as not tested

Download all attachments as: .zip

Change History (23)

comment:1 Changed 9 years ago by demosd235

Add a comment to a ticket here.

comment:2 Changed 9 years ago by demosd235

  • Status changed from new to needs_review

Is this ready yet?

comment:3 Changed 9 years ago by aapitzsch

According to http://www.sagemath.org/doc/developer/conventions.html#docstring-markup-with-rest-and-sphinx it should be EXAMPLES: instead of EXAMPLE::.

It's enough to put only 3 dots between <BLANKLINE> and System but this is okay as well.

comment:4 Changed 8 years ago by mariah

  • Status changed from needs_review to needs_work

comment:5 Changed 8 years ago by rbeezer

  • Status changed from needs_work to needs_info

If an "EXAMPLES" block just has one example, then it is OK to drop the S. And if there is no prose before the test, then a double-colon can be used to indicate verbatim text next.

There are excess ... but they cause no harm. This ticket looks good to me. Am I missing something? It looks ready for a positive review to me.

I am working on this as a high-priority ticket for Bug Days 32.

Rob

comment:6 Changed 8 years ago by benjaminfjones

  • Reviewers set to rbeezer, benjaminfjones

The patch looks good to me and passes doctests:

bjones@sage:~/sage/sage-4.7.1/devel/sage$ ../../sage -t sage/tests/benchmark.py 
sage -t  "devel/sage-9494/sage/tests/benchmark.py"          
	 [8.6 s]
 
----------------------------------------------------------------------
All tests passed!
Total time for all tests: 8.6 seconds

I'm giving it a positive review.

comment:7 Changed 8 years ago by benjaminfjones

  • Status changed from needs_info to needs_review

comment:8 Changed 8 years ago by benjaminfjones

  • Status changed from needs_review to positive_review

comment:9 Changed 8 years ago by benjaminfjones

  • Reviewers changed from rbeezer, benjaminfjones to Rob Beezer, Benjamin Jones

comment:10 Changed 8 years ago by was

  • Keywords sd32 added

comment:11 Changed 8 years ago by leif

  • Description modified (diff)

comment:12 Changed 8 years ago by leif

  • Status changed from positive_review to needs_work
  • Work issues set to Fix `mpoly_all()` or mark the doctest `# not tested`.

Actually, mpoly_all() needs work, since it is apparently unable to interrupt (e.g.) Mathematica a second time.

On redhawk, where /home still isn't mounted, Mathematica is installed but fails to startup (prompting the user), such that I get:

leif@redhawk:/$ time sage -c "from sage.tests.benchmark import mpoly_all; mpoly_all()" 



Compute (x_0 + ... + x_99) * (x_100 + ... + x_200) over Rational Field (use singular for Sage mult.)
  System      min         avg         max         trials          cpu or wall
* sage        0.049767    0.049767    0.049767    1                  0.049767w
Unable to start magma
computation timed out because alarm was set for 60 seconds
Unable to start macaulay2 because the command 'M2 --no-debug --no-readline --silent -e 'ZZ#{Standard,Core#"private dictionary"#"InputPrompt"} = lineno -> "_EGAS_ : ";ZZ#{Standard,Core#"private dictionary"#"InputContinuationPrompt"} = lineno -> "_EGAS_ : ";printWidth = 0;lineNumber = 10^9;'' failed.




Compute (x_0 + ... + x_199) * (x_200 + ... + x_400) over Rational Field (use singular for Sage mult.)
  System      min         avg         max         trials          cpu or wall
* sage        0.089736    0.089736    0.089736    1                  0.089736w
Unable to start magma
Interrupting Mathematica...

which does not terminate.

What is this doctest supposed to "test" at all?

The output is random, so it doesn't really test anything, except perhaps which external programs are installed, but that's nothing subject to a doctest, so IMHO this ticket should either be closed as invalid, or the "doctest" (i.e., the example) should be marked # not tested, at least until mpoly_all() got fixed.

Changed 7 years ago by benjaminfjones

marked mpoly_all() as not tested

comment:13 Changed 7 years ago by benjaminfjones

  • Description modified (diff)
  • Status changed from needs_work to needs_review
  • Work issues Fix `mpoly_all()` or mark the doctest `# not tested`. deleted

comment:14 Changed 7 years ago by benjaminfjones

I marked mpoly_all() as # not tested. The new patch applied cleanly to 5.0.beta12 and passes tests on sage.math.washington.edu where Mma is installed. I'm running tests on redhawk now to double check.

comment:15 Changed 7 years ago by benjaminfjones

There seems to still be an issue with the Mma installation on redhawk and the mpoly_all() test is still unable to interrupt the crashed process all the time:

Compute (x_1 + 2*x_2 + 3*x_3 + ... + 128*x_128) * (129 * x_129 + ... + 257*x_257) over Rational Field (use singular for Sage mult.)
  System      min         avg         max         trials          cpu or wall
* sage        0.049826    0.049826    0.049826    1                  0.049826w
Unable to start magma
Mathematica crashed -- automatically restarting.
computation timed out because alarm was set for 60 seconds
Unable to start macaulay2 because the command 'M2 --no-debug --no-readline --silent -e 'ZZ#{Standard,Core#"private dictionary"#"InputPrompt"} = lineno -> "_EGAS_ : ";ZZ#{Standard,Core#"private dictionary"#"InputContinuationPrompt"} = lineno -> "_EGAS_ : ";printWidth = 0;lineNumber = 10^9;'' failed.




Compute (x_1 + 2*x_2 + 3*x_3 + ... + 256*x_256) * (257 * x_257 + ... + 513*x_513) over Rational Field (use singular for Sage mult.)
  System      min         avg         max         trials          cpu or wall
* sage        0.149662    0.149662    0.149662    1                  0.149662w
Unable to start magma
Interrupting Mathematica...
^C
Unable to start macaulay2 because the command 'M2 --no-debug --no-readline --silent -e 'ZZ#{Standard,Core#"private dictionary"#"InputPrompt"} = lineno -> "_EGAS_ : ";ZZ#{Standard,Core#"private dictionary"#"InputContinuationPrompt"} = lineno -> "_EGAS_ : ";printWidth = 0;lineNumber = 10^9;'' failed.

But I'd say that's an issue for another ticket.

comment:16 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:17 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:18 Changed 5 years ago by rws

  • Branch set to u/rws/ticket/9494
  • Modified changed from 01/30/14 21:20:52 to 01/30/14 21:20:52

comment:19 Changed 5 years ago by rws

  • Commit set to 1803137ae4c88a1e6015e5b58498947c906c92af
  • Reviewers changed from Rob Beezer, Benjamin Jones to Rob Beezer, Benjamin Jones, Ralf Stephan
  • Status changed from needs_review to positive_review
  • Summary changed from Add a doctest to benchmark.py to marked mpoly_all() as not tested

Moved patch to git.


New commits:

1803137trac #9494: marked mpoly_all() as not tested

comment:20 Changed 5 years ago by git

  • Commit changed from 1803137ae4c88a1e6015e5b58498947c906c92af to 6f109fad8d6bf24f2622c3f11ca4104445dbe57a
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

6f109faMerge branch 'develop' into ticket/9494

comment:21 Changed 5 years ago by rws

  • Status changed from needs_review to positive_review

comment:22 Changed 5 years ago by vbraun

  • Branch changed from u/rws/ticket/9494 to 6f109fad8d6bf24f2622c3f11ca4104445dbe57a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.