Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#9476 closed enhancement (fixed)

Upgrade eclib to version 20100711

Reported by: cremona Owned by: tbd
Priority: minor Milestone: sage-4.5.3
Component: packages: standard Keywords: eclib modular symbols
Cc: was, wuthrich Merged in: sage-4.5.3.alpha0
Authors: John Cremona Reviewers: Robert Miller
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by cremona)

I have made several enhancements to eclib:

  1. Support for minus space modular symbols
  2. Some sparse linear algebra improvements

The new version is called eclib-20100711 since it is more than just a patch-level change. See below for a link to the spkg.

The interface in sage/libs/cremona has been updated accordingly in the patch; this depends on #9441

Attachments (2)

trac_9476-eclib.patch (13.3 KB) - added by cremona 7 years ago.
Applies after eclib-20100711.patch and trac_9441-atkin-lehner.patch
trac_9476-remove-not-implemented-error.patch (2.1 KB) - added by rlm 7 years ago.

Download all attachments as: .zip

Change History (19)

Changed 7 years ago by cremona

Applies after eclib-20100711.patch and trac_9441-atkin-lehner.patch

comment:2 Changed 7 years ago by cremona

  • Description modified (diff)
  • Status changed from new to needs_review

comment:3 Changed 7 years ago by rlm

I'm reviewing this and #9441 at the same time. So far it compiles just fine with sage-4.5 final, on Intel OS X 10.6.4, and I'm currently running tests. I'll also give it a try on geom.math, which has begun at the moment.

comment:4 Changed 7 years ago by rlm

  • Reviewers set to Robert Miller
  • Status changed from needs_review to positive_review

Looks good on OS X. Same on geom.math.

comment:5 Changed 7 years ago by rlm

  • Status changed from positive_review to needs_work

Small reviewer patch coming up in a minute!

comment:6 Changed 7 years ago by cremona

Thanks!

comment:7 Changed 7 years ago by rlm

  • Status changed from needs_work to needs_info

Hmm. I think this might have something to do with one of the things I saw on #9247.

I'm attaching the reviewer patch, which causes the following:

sage -t  "devel/sage-main/sage/schemes/elliptic_curves/ell_modular_symbols.py"
**********************************************************************
File "/Users/rlmill/sage-4.5.eclib-test/devel/sage-main/sage/schemes/elliptic_curves/ell_modular_symbols.py", line 429:
    sage: M=sage.schemes.elliptic_curves.ell_modular_symbols.ModularSymbolECLIB(E,-1)
Expected nothing
Got:
    Warning : Could not normalize the modular symbols, maybe all further results will be multiplied by -1, 2 or -2.
**********************************************************************
File "/Users/rlmill/sage-4.5.eclib-test/devel/sage-main/sage/schemes/elliptic_curves/ell_modular_symbols.py", line 438:
    sage: M=sage.schemes.elliptic_curves.ell_modular_symbols.ModularSymbolECLIB(E,-1)
Expected nothing
Got:
    Warning : Could not normalize the modular symbols, maybe all further results will be multiplied by -1, 2 or -2.
**********************************************************************

John,

Can you give some info about what's going on here?

comment:8 Changed 7 years ago by cremona

  • Cc wuthrich added

I have added Chris W to the CC list since we'll need his input, as he wrote ell_modular_symbols.

I agree that that file needs updating as a consequence of my upgrade; but that can be done on a separate ticket?

comment:9 Changed 7 years ago by rlm

John,

I thought that eclib was propagating that warning, but clearly it's coming from ell_modular_symbols.py. Have a look at the new ref patch, and let me know what you think.

comment:10 Changed 7 years ago by rlm

  • Status changed from needs_info to needs_review

comment:11 Changed 7 years ago by was

  • Status changed from needs_review to positive_review

reviewer addendum looks good to me.

comment:12 Changed 7 years ago by mpatel

I'm having difficulty getting the new package:

$ wget http://www.warwick.ac.uk/staff/J.E.Cremona/eclib-20100711.spkg
--19:50:47--  http://www.warwick.ac.uk/staff/J.E.Cremona/eclib-20100711.spkg
           => `eclib-20100711.spkg'
Resolving www.warwick.ac.uk... 137.205.243.107
Connecting to www.warwick.ac.uk|137.205.243.107|:80... connected.
HTTP request sent, awaiting response... 

Can someone check its availability and perhaps put a copy on the Sage cluster?

Also, should I apply both patches, too?

comment:13 Changed 7 years ago by mpatel

  • Status changed from positive_review to needs_info

comment:14 Changed 7 years ago by mpatel

  • Status changed from needs_info to needs_review

The package is available now. I'll include both patches.

comment:15 Changed 7 years ago by mpatel

  • Status changed from needs_review to positive_review

comment:16 Changed 7 years ago by mpatel

  • Merged in set to sage-4.5.3.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:17 Changed 7 years ago by cremona

Sorry not to have responded earlier but I was on holiday for a few days. I think they were doing some network updating at U of Warwick, which could explain why you could not get the file. Glad it's fixed -- and thanks for the review.

Note: See TracTickets for help on using tickets.