#9476 closed enhancement (fixed)
Upgrade eclib to version 20100711
Reported by: | cremona | Owned by: | tbd |
---|---|---|---|
Priority: | minor | Milestone: | sage-4.5.3 |
Component: | packages: standard | Keywords: | eclib modular symbols |
Cc: | was, wuthrich | Merged in: | sage-4.5.3.alpha0 |
Authors: | John Cremona | Reviewers: | Robert Miller |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
I have made several enhancements to eclib:
- Support for minus space modular symbols
- Some sparse linear algebra improvements
The new version is called eclib-20100711 since it is more than just a patch-level change. See below for a link to the spkg.
The interface in sage/libs/cremona has been updated accordingly in the patch; this depends on #9441
Attachments (2)
Change History (19)
comment:1 Changed 7 years ago by
comment:2 Changed 7 years ago by
- Description modified (diff)
- Status changed from new to needs_review
comment:3 Changed 7 years ago by
I'm reviewing this and #9441 at the same time. So far it compiles just fine with sage-4.5 final, on Intel OS X 10.6.4, and I'm currently running tests. I'll also give it a try on geom.math, which has begun at the moment.
comment:4 Changed 7 years ago by
- Reviewers set to Robert Miller
- Status changed from needs_review to positive_review
Looks good on OS X. Same on geom.math.
comment:5 Changed 7 years ago by
- Status changed from positive_review to needs_work
Small reviewer patch coming up in a minute!
comment:6 Changed 7 years ago by
Thanks!
comment:7 Changed 7 years ago by
- Status changed from needs_work to needs_info
Hmm. I think this might have something to do with one of the things I saw on #9247.
I'm attaching the reviewer patch, which causes the following:
sage -t "devel/sage-main/sage/schemes/elliptic_curves/ell_modular_symbols.py" ********************************************************************** File "/Users/rlmill/sage-4.5.eclib-test/devel/sage-main/sage/schemes/elliptic_curves/ell_modular_symbols.py", line 429: sage: M=sage.schemes.elliptic_curves.ell_modular_symbols.ModularSymbolECLIB(E,-1) Expected nothing Got: Warning : Could not normalize the modular symbols, maybe all further results will be multiplied by -1, 2 or -2. ********************************************************************** File "/Users/rlmill/sage-4.5.eclib-test/devel/sage-main/sage/schemes/elliptic_curves/ell_modular_symbols.py", line 438: sage: M=sage.schemes.elliptic_curves.ell_modular_symbols.ModularSymbolECLIB(E,-1) Expected nothing Got: Warning : Could not normalize the modular symbols, maybe all further results will be multiplied by -1, 2 or -2. **********************************************************************
John,
Can you give some info about what's going on here?
comment:8 Changed 7 years ago by
- Cc wuthrich added
I have added Chris W to the CC list since we'll need his input, as he wrote ell_modular_symbols.
I agree that that file needs updating as a consequence of my upgrade; but that can be done on a separate ticket?
comment:9 Changed 7 years ago by
John,
I thought that eclib was propagating that warning, but clearly it's coming from ell_modular_symbols.py. Have a look at the new ref patch, and let me know what you think.
Changed 7 years ago by
comment:10 Changed 7 years ago by
- Status changed from needs_info to needs_review
comment:11 Changed 7 years ago by
- Status changed from needs_review to positive_review
reviewer addendum looks good to me.
comment:12 Changed 7 years ago by
I'm having difficulty getting the new package:
$ wget http://www.warwick.ac.uk/staff/J.E.Cremona/eclib-20100711.spkg --19:50:47-- http://www.warwick.ac.uk/staff/J.E.Cremona/eclib-20100711.spkg => `eclib-20100711.spkg' Resolving www.warwick.ac.uk... 137.205.243.107 Connecting to www.warwick.ac.uk|137.205.243.107|:80... connected. HTTP request sent, awaiting response...
Can someone check its availability and perhaps put a copy on the Sage cluster?
Also, should I apply both patches, too?
comment:13 Changed 7 years ago by
- Status changed from positive_review to needs_info
comment:14 Changed 7 years ago by
- Status changed from needs_info to needs_review
The package is available now. I'll include both patches.
comment:15 Changed 7 years ago by
- Status changed from needs_review to positive_review
comment:16 Changed 7 years ago by
- Merged in set to sage-4.5.3.alpha0
- Resolution set to fixed
- Status changed from positive_review to closed
comment:17 Changed 7 years ago by
Sorry not to have responded earlier but I was on holiday for a few days. I think they were doing some network updating at U of Warwick, which could explain why you could not get the file. Glad it's fixed -- and thanks for the review.
The new spkg is here: http://www.warwick.ac.uk/staff/J.E.Cremona/eclib-20100711.spkg