Opened 11 years ago

Closed 11 years ago

#9462 closed defect (fixed)

warning in matrix_modn_dense.pyx

Reported by: wjp Owned by: GeorgSWeber
Priority: minor Milestone: sage-4.5.2
Component: build Keywords:
Cc: Merged in: sage-4.5.2.alpha1
Authors: Willem Jan Palenstijn Reviewers: John Palmieri
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by wjp)

cython gives a warning when compiling matrix_modn_dense.pyx:

warning: /data2/wpalenst/sage-4.5.alpha4/devel/sage-main/sage/matrix/matrix_modn_dense.pyx:105:8: Function signature does not match previous declaration

I've uploaded a patch that removes the duplicate declaration (of memcpy), and also removes the unused declaration of memcmp.

Attachments (1)

trac_9462_duplicate_decl.patch (764 bytes) - added by wjp 11 years ago.

Download all attachments as: .zip

Change History (5)

Changed 11 years ago by wjp

comment:1 Changed 11 years ago by wjp

  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 Changed 11 years ago by wjp

  • Milestone changed from sage-5.0 to sage-4.5.1

comment:3 Changed 11 years ago by jhpalmieri

  • Authors set to Willem Jan Palenstijn
  • Reviewers set to John Palmieri
  • Status changed from needs_review to positive_review

The patch makes the warning go away and all tests pass afterwards. Since the declaration is already included via include "../ext/cdefs.pxi", getting rid of the extra one looks fine. Positive review.

comment:4 Changed 11 years ago by ddrake

  • Merged in set to sage-4.5.2.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.