Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#9456 closed defect (fixed)

zlib should be a prerequisite for libpng

Reported by: jhpalmieri Owned by: tbd
Priority: blocker Milestone: sage-4.5.2
Component: distribution Keywords:
Cc: drkirkby Merged in: sage-4.5.2.alpha1
Authors: John Palmieri Reviewers: David Kirkby
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

From the libpng INSTALL file:

Before installing libpng, you must first install zlib

So fix the file "deps" accordingly. (This issue arose when building spkg's in parallel: the build failed when it reached libpng because zlib wasn't installed yet.)

Attachments (2)

deps (18.2 KB) - added by drkirkby 9 years ago.
spkg/standard/deps file, written by John and merged into sage-4.5.2.alpha1 which I overwrote by mistake. I'm 99% sure this is right.
deps.diff (430 bytes) - added by drkirkby 9 years ago.
diff of spkg/standard/deps written by john which I overwrote by mistake. I'm 99% sure this is right.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 9 years ago by drkirkby

  • Status changed from new to needs_review

That's perfectly logical. Positive review.

comment:2 Changed 9 years ago by drkirkby

  • Status changed from needs_review to positive_review

comment:3 Changed 9 years ago by jhpalmieri

  • Priority changed from major to blocker

I'm upgrading this to a blocker because there is a patch and I hit it every time I try to build sage on the skynet machine iras with parallel spkg building: the build fails on libpng, then I have to restart it. (Usually libpng and zlib are built at the same time on this machine, so after libpng fails, zlib builds successfully, so running "make" again works fine.)

comment:4 Changed 9 years ago by ddrake

  • Authors set to John Palmieri
  • Merged in set to sage-4.5.2.alpha1
  • Resolution set to fixed
  • Reviewers set to David Kirkby
  • Status changed from positive_review to closed

I've put the deps file here in SAGE_ROOT/spkg/standard for 4.5.2.alpha1.

comment:5 follow-up: Changed 9 years ago by drkirkby

I'm sorry, I have screwed up here, and attached these files to the wrong ticket! Instead of attaching them to #9598, I've attached them here.

Since this has not been merged, it's probably not a fatal screw up. Sorry.

I will attempt to put the files back as they should be.

comment:6 in reply to: ↑ 5 Changed 9 years ago by drkirkby

Replying to drkirkby:

Since this has not been merged, it's probably not a fatal screw up. Sorry.

I mean it has been merged, so it should not be a big deal. But I will attempt to put the files back as they should be.

comment:7 Changed 9 years ago by drkirkby

I've tried to correct this, but have failed. I'm going to delete this, and raise it on sage-devel.

Dave

Changed 9 years ago by drkirkby

spkg/standard/deps file, written by John and merged into sage-4.5.2.alpha1 which I overwrote by mistake. I'm 99% sure this is right.

Changed 9 years ago by drkirkby

diff of spkg/standard/deps written by john which I overwrote by mistake. I'm 99% sure this is right.

comment:8 Changed 9 years ago by drkirkby

I believe these are correct. Perhaps someone else can check.

Dave

Note: See TracTickets for help on using tickets.