Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#9441 closed defect (fixed)

Atkin-Lehner operators for Cremona modular symbols

Reported by: cremona Owned by: craigcitro
Priority: minor Milestone: sage-4.5.2
Component: modular forms Keywords: modular symbols
Cc: was Merged in: sage-4.5.2.alpha0
Authors: John Cremona Reviewers: Robert Miller
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

The code in sage/libs/cremona wraps some of Cremona's modular symbols code, including Hecke operators. The wrapping function incorrectly assumes that the function heckeop(p) only works for primes p not dividing the level, when in fact it works fine for primes dividing the level, in that case returning the matrix of the Atkin-Lehner involution.

The patch remedies this, with some tests.

Attachments (1)

trac_9441-atkin-lehner.patch (2.5 KB) - added by cremona 11 years ago.
Applies to 4.5.alpha3

Download all attachments as: .zip

Change History (5)

Changed 11 years ago by cremona

Applies to 4.5.alpha3

comment:1 Changed 11 years ago by cremona

  • Status changed from new to needs_review

comment:2 Changed 11 years ago by rlm

  • Reviewers set to Robert Miller
  • Status changed from needs_review to positive_review

Looks good to me! Applies, passes tests.

comment:3 Changed 11 years ago by mpatel

  • Merged in set to sage-4.5.2.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:4 Changed 11 years ago by mvngu

  • Milestone changed from sage-5.0 to sage-4.5.2
Note: See TracTickets for help on using tickets.