Opened 9 years ago

Closed 9 years ago

#9413 closed defect (fixed)

Bug in tamagawa_product_bsd for elliptic curves over QQ

Reported by: davidloeffler Owned by: cremona
Priority: minor Milestone: sage-4.6
Component: elliptic curves Keywords:
Cc: Merged in: sage-4.6.alpha1
Authors: Chris Wuthrich Reviewers: John Cremona
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

sage: E = EllipticCurve('30a')
sage: E.tamagawa_product_bsd()
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)

/storage/masiao/sage-4.5.alpha1/devel/sage-reviewing/sage/schemes/elliptic_curves/<ipython console> in <module>()

/storage/masiao/sage-4.5.alpha1/local/lib/python2.6/site-packages/sage/schemes/elliptic_curves/ell_number_field.pyc in tamagawa_product_bsd(self)
   1144             # the differential associated to this particular equation E
   1145             uu = self.isomorphism_to(dav.minimal_model()).u
-> 1146             uu_abs_val = pp.smallest_integer()**(pp.residue_class_degree()*valuation(uu,pp))
   1147             pr *= cv * uu_abs_val
   1148         return pr

/storage/masiao/sage-4.5.alpha1/local/lib/python2.6/site-packages/sage/structure/element.so in sage.structure.element.Element.__getattr__ (sage/structure/element.c:2632)()

/storage/masiao/sage-4.5.alpha1/local/lib/python2.6/site-packages/sage/structure/parent.so in sage.structure.parent.getattr_from_other_class (sage/structure/parent.c:2835)()

/storage/masiao/sage-4.5.alpha1/local/lib/python2.6/site-packages/sage/structure/parent.so in sage.structure.parent.raise_attribute_error (sage/structure/parent.c:2629)()

AttributeError: 'Ideal_pid' object has no attribute 'smallest_integer'

Attachments (1)

trac_9413.patch (1.8 KB) - added by wuthrich 9 years ago.

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by wuthrich

comment:1 Changed 9 years ago by wuthrich

  • Authors set to Chris Wuthrich
  • Status changed from new to needs_review

comment:2 Changed 9 years ago by cremona

  • Reviewers set to John Cremona
  • Status changed from needs_review to positive_review

Looks fine, applies ok to 4.5.3.alpha1 (with a little fuzz) and all tests in ell_number_field pass (no other files call this function).

comment:3 Changed 9 years ago by mpatel

  • Merged in set to sage-4.6.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.