Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#9403 closed enhancement (fixed)

preimage method in NumberFieldHomomorphism_im_gens

Reported by: Jeremy West Owned by: Alex Ghitza
Priority: major Milestone: sage-4.5.2
Component: algebra Keywords: number field, embedding, homomorphism, preimage
Cc: ebeyerstedt, Francis Clarke, David Loeffler Merged in: sage-4.5.2.alpha1
Authors: Jeremy West Reviewers: Aly Deines
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

I am adding a preimage method in the NumberFieldHomomorphism_im_gens class. There may be a better or more general place to put this, but we need it for the descend_to method in EllipticCurve? so I am putting it there for now.

Attachments (3)

trac_9403-preimage.patch (2.7 KB) - added by Jeremy West 12 years ago.
A preimage method for NumberFieldHomomorphism?
trac_9403-new.patch (3.1 KB) - added by ebeyerstedt 12 years ago.
Replaces previous patch.
trac_9403-error_handling.patch (3.2 KB) - added by Jeremy West 12 years ago.
Fixes error handling message, replaces all previous patches.

Download all attachments as: .zip

Change History (19)

comment:1 Changed 12 years ago by Jeremy West

Cc: ebeyerstedt added
Status: newneeds_work

Changed 12 years ago by Jeremy West

Attachment: trac_9403-preimage.patch added

A preimage method for NumberFieldHomomorphism?

comment:2 Changed 12 years ago by Jeremy West

Status: needs_workneeds_review

I have implemented the preimage method including documentation and tests. I just need a review now. Let me know if this should go somewhere better.

comment:3 Changed 12 years ago by ebeyerstedt

The new patch changes each usage of .vector_space to .absolute_vector_space. Also added a doctest.

Changed 12 years ago by ebeyerstedt

Attachment: trac_9403-new.patch added

Replaces previous patch.

comment:4 Changed 12 years ago by ebeyerstedt

Updated documentation.

comment:5 Changed 12 years ago by John Cremona

Cc: Francis Clarke David Loeffler added

comment:6 Changed 12 years ago by Alyson Deines

Status: needs_reviewpositive_review

comment:7 Changed 12 years ago by Jeremy West

I changed the error message that is returned when the input is not in the image of the homomorphism so that, rather than a message about solving a matrix equation, it gives a message about the input not being in the image.

comment:8 Changed 12 years ago by David Loeffler

Status: positive_reviewneeds_work

If you really must upload new patches to an already positively reviewed ticket, you *must* put the status back to "needs review".

comment:9 Changed 12 years ago by David Loeffler

Status: needs_workneeds_review

Changed 12 years ago by Jeremy West

Fixes error handling message, replaces all previous patches.

comment:10 Changed 12 years ago by Dan Drake

David -- can you review the newest patch? If this ticket can get a positive review, then it and #9384 can get into 4.5.2.

comment:11 Changed 12 years ago by Alyson Deines

Status: needs_reviewpositive_review

comment:12 Changed 12 years ago by Dan Drake

Merged in: sage-4.5.2.alpha1
Resolution: fixed
Status: positive_reviewclosed

Please include the ticket number in your commit messages! Also, Jeremy, you might want to set your username in your .hgrc file -- your patch has a username of "jeremy@…".

comment:13 Changed 12 years ago by Mitesh Patel

Milestone: sage-5.0sage-4.5.2

comment:14 Changed 12 years ago by Mitesh Patel

Reviewers: Aly Deines

I'm entering a guess for the Reviewer(s) field. Please correct me if I'm wrong.

comment:15 Changed 12 years ago by Mitesh Patel

Reviewers: Aly DeinesAlyson Deines

comment:16 Changed 12 years ago by Alyson Deines

Reviewers: Alyson DeinesAly Deines
Note: See TracTickets for help on using tickets.